-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
build: Propagate link_language instead of internals #15450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Yes, I think it should be replicated, and the combined loop could be something like this: |
3a0aa14 to
38c851d
Compare
|
@bonzini ok, your code was missing the The only problem that still exists is the lacking introspection from the vs backend. Should I just limit the testcase to ninja or is there a better way of detecting the linker a target is going to use? |
Yeah, that makes sense but please add a comment. |
a07a071 to
21a028c
Compare
I guess the skip reason works well enough for that :) |
e0a7979 to
4dad829
Compare
dcbaker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small nits, otherwise this looks good to me.
4dad829 to
1b76611
Compare
|
Will re-trigger CI once GitHub actions are back up and running properly again |
If a build target has link_language set, use that instead of propagating the language the target was written in. This fixes the issue, that if you have a build target with cpp sources but with link_language being set to 'c', targets which link against the build target will be linked with the cpp linker, even tho that isn't necessary.
1b76611 to
4225608
Compare
If a build target has link_language set, use that instead of propagating the language the target was written in.
This fixes the issue, that if you have a build target with cpp sources but with link_language being set to 'c', targets which link against the build target will be linked with the cpp linker, even tho that isn't necessary.
The non-link_language branch has some special casing for rust, which might have to be replicated in the new branch too. I'm not quite sure what exactly is does, so I'd appreciate some feedback on if that is necessary.