build: calculate BuildTarget.link_langauge if it's not set in the DSL #15509
+61
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcbaker
changed the title
dcbaker
force-pushed
the
submit/calculate-link-langauge-once
branch
4 times, most recently
from
9c95570 to
644a28c
Compare
dnicolodi
reviewed
Jan 31, 2026
| self.builddir, name, self.type_suffix()) | ||
|
|
||
| def _calculcate_link_language(self) -> Language: | ||
| def calculate() -> Language: |
Member
There was a problem hiding this comment.
Why is this logic defined as a function? It looks like it could be simply executed inline.
Member
Author
There was a problem hiding this comment.
Because doing it inline requires a lot of null checking, while using a closure makes it much cleaner, the closure can just return when language is found instead.
lang: T.Optional[Language] = None
if self.uses_rust():
...
lang = 'rust'
if lang is None and not languages:
...
if lang is None:
lang = languages[0]
if lang not in self.all_compilers:
...
return lang
dnicolodi
reviewed
Jan 31, 2026
dnicolodi
reviewed
Jan 31, 2026
dnicolodi
reviewed
Jan 31, 2026
Contributor
|
Is #15450 still going to be needed after this? |
Member
Author
|
@sp1ritCS: I think it still is. This mainly is optimizing the situation where we basically do the same calculation multiple times in multiple places, and what you're doing is orthogonal to that, and what you're doing will help make some of the work I want to do as follow up to this much easier. So, I will go review that. |
We more-or-less calculate the link_language several times if the user doesn't pass it, so let's calculate it ourselves.
dcbaker
force-pushed
the
submit/calculate-link-langauge-once
branch
from
644a28c to
37bbb9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We effectively do this multiple times otherwise, even though we have all of the information to do it up front once. This simplifies a bunch of code later, and should allow us to do more cleanups later on.