Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: packet addCreatureIcon issues : #971 #972

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

kokekanon
Copy link
Collaborator

@kokekanon kokekanon commented Nov 20, 2024

Description

miss for
here
image

Only fix packets , no feature

Behavior

Actual

Packet Error

Expected

Do this and that happens

Fixes

#971

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

tfs 13.10

local spawn = GlobalEvent("spawnStartup")
function spawn.onStartup()
		local m = Game.createMonster("Demon", {x = 95, y = 121, z = 7}, true, true)
		m:setSpecialIcon(5,0)
		m:setIcon(CREATURE_ICON_PIGEON,0)
		m:setIcon(CREATURE_ICON_QUESTION,1)
end
spawn:register()

canary 13.40

local spawn = GlobalEvent("spawnStartup")
function spawn.onStartup()
		local m = Game.createMonster("Demon",Position(32335, 32189, 7), true, true)
	
		m:setIcon("magma-bubble",0,4)
		m:setIcon("goshnars-hatred-damage",1,7)
end
spawn:register()

Test Configuration:

  • Server Version: 13.10
  • Client: this pr
  • Operating System: 11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@kokekanon kokekanon marked this pull request as draft November 20, 2024 14:08
@kokekanon kokekanon marked this pull request as ready for review November 20, 2024 14:13
Copy link

sonarcloud bot commented Nov 20, 2024

@luanluciano93 luanluciano93 merged commit b6cb2d1 into mehah:main Nov 21, 2024
11 checks passed
@kokekanon kokekanon mentioned this pull request Nov 28, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants