fix: packet addCreatureIcon issues : #971 (#972)

mehah · Nov 21, 2024 · b6cb2d1 · b6cb2d1
1 parent fb8123e
commit b6cb2d1
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 8 deletions.
diff --git a/data/images/game/creatureicons/CreatureIcons.png b/data/images/game/creatureicons/CreatureIcons.png
diff --git a/data/images/game/creatureicons/monsterIcons.png b/data/images/game/creatureicons/monsterIcons.png
diff --git a/src/client/protocolgame.h b/src/client/protocolgame.h
@@ -230,7 +230,7 @@ class ProtocolGame : public Protocol
     void parseItemClasses(const InputMessagePtr& msg);
     void parseCreatureMark(const InputMessagePtr& msg);
     void parseTrappers(const InputMessagePtr& msg);
-    void addCreatureIcon(const InputMessagePtr& msg);
+    void addCreatureIcon(const InputMessagePtr& msg) const;
     void parseCloseForgeWindow(const InputMessagePtr& msg);
     void parseCreatureData(const InputMessagePtr& msg);
     void parseCreatureHealth(const InputMessagePtr& msg);

diff --git a/src/client/protocolgameparse.cpp b/src/client/protocolgameparse.cpp
@@ -1835,7 +1835,7 @@ void ProtocolGame::parseTrappers(const InputMessagePtr& msg)
     }
 }
 
-void ProtocolGame::addCreatureIcon(const InputMessagePtr& msg)
+void ProtocolGame::addCreatureIcon(const InputMessagePtr& msg) const
 {
     const uint8_t sizeIcons = msg->getU8();
     for (auto i = 0; i < sizeIcons; ++i) {
@@ -3368,12 +3368,7 @@ CreaturePtr ProtocolGame::getCreature(const InputMessagePtr& msg, int type) cons
         const uint16_t speed = msg->getU16();
 
         if (g_game.getClientVersion() >= 1281) {
-            const uint8_t iconDebuff = msg->getU8(); // creature debuffs
-            if (iconDebuff != 0) {
-                msg->getU8(); // Icon
-                msg->getU8(); // Update (?)
-                msg->getU16(); // Counter text
-            }
+            addCreatureIcon(msg);
         }
 
         const uint8_t skull = msg->getU8();