Skip to content

Conversation

@paulpascal
Copy link
Contributor

@paulpascal paulpascal force-pushed the 191_superset_integration branch from fe75d9b to 19b9ab7 Compare March 17, 2025 18:55
@paulpascal paulpascal force-pushed the 191_superset_integration branch from 19b9ab7 to 3622b1a Compare March 17, 2025 18:57
@paulpascal paulpascal marked this pull request as ready for review March 17, 2025 19:02
Copy link
Collaborator

@mrjones-plip mrjones-plip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really love the intention behind this PR! Making it easier to create superset users and to have a script to handle setting up encryption is powerful!

I'm just commenting on the manage-secrets.sh part of the PR. I did not test this or look at any of the type script. I'm using the conventional commits system for feedback.

I think the manage-secrets.sh has very good intentions, but I have concerns about shipping it to first time users. While I see a substantial amount of work was put in (and then I gave specific feedback on that work!) The reason is that sops already has a whole work flow that we're then wrapping a bash script around. I had quite a bit of difficulty getting the script work and it failed open (cleartext secrets on disk). While we might be able to fix these, I fear even more confusion might ensure by end users who don't appreciate the severity of their actions.

Instead, if we greatly simplify the process to document the sops usage steps in the readme, users will know they're encrypting files, leaving files in the clear occasionally, and will know how to debug anything if the secrets file or sops has any issues. I think documenting a happy path to create the secrets file should be pretty straight forward!

Finally - I realize we don't specify which env vars go into the secrets file. Or did I miss that and we do?

I'd like to hear what @Hareet has to say!

@paulpascal
Copy link
Contributor Author

Woo @mrjones-plip, that was quick, thanks for looking into this, I am going to carefully check your feedback

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome work. Something else to consider is the update flow; for roles and RLS. As new tables are added, the permissions need to be updated for both the template and all other roles created from it.

Copy link
Collaborator

@mrjones-plip mrjones-plip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing my feedback!

I gave the script another try and hit some snags - see comments below.

Copy link
Collaborator

@mrjones-plip mrjones-plip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had another thought on simplifying encryption process! See below

@paulpascal paulpascal force-pushed the 191_superset_integration branch 2 times, most recently from 3d66b7a to 78fb70c Compare March 20, 2025 17:13
@paulpascal paulpascal force-pushed the 191_superset_integration branch from 78fb70c to 92a14fb Compare March 20, 2025 17:19
@mrjones-plip
Copy link
Collaborator

@paulpascal Sorry if I didn't follow up - do you need more review from me? Lemme know - happy to help

Copy link

@alexosugo alexosugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Looking forward to seeing this in action. We should consider the update flows as well in later iterations; for (re)moved users and scope changes for roles and RLS.

@paulpascal paulpascal linked an issue May 19, 2025 that may be closed by this pull request
@paulpascal paulpascal changed the title feat: integrating superset feat: integrate superset feature Jun 2, 2025
@paulpascal paulpascal force-pushed the 191_superset_integration branch from 13af92f to b223401 Compare July 16, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support superset user management

6 participants