Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chromium data for privacy Web Extensions api properties #24527

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

danielhjacobs
Copy link
Contributor

Summary

The privacy API, at the time already containing both services.alternateErrorPagesEnabled and services.autofillEnabled, was moved out of the experimental status in https://source.chromium.org/chromium/chromium/src/+/607e6522f841933e0d3130c09d33207876850948, which according to https://source.chromium.org/chromium/chromium/src/+/607e6522f841933e0d3130c09d33207876850948:chrome/VERSION was Chrome 18.

This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the privacy Web Extensions api property network.httpsOnlyMode. This sets the feature(s) to a version range based upon the date that the feature was added to BCD with the intent of replacing true values with ranged values to eliminate true values from BCD.

Commit/PR Adding the Feature: #8830

This needs the "KR: Real BCD" label

Test results and supporting details

https://source.chromium.org/chromium/chromium/src/+/607e6522f841933e0d3130c09d33207876850948
#8830

Related issues

openwebdocs/project#206

The privacy API, at the time already containing both services.alternateErrorPagesEnabled and services.autofillEnabled, was moved out of the experimental status in https://source.chromium.org/chromium/chromium/src/+/607e6522f841933e0d3130c09d33207876850948, which according to https://source.chromium.org/chromium/chromium/src/+/607e6522f841933e0d3130c09d33207876850948:chrome/VERSION was Chrome 18.
…yMode

This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `privacy` Web Extensions api properties. This sets the feature(s) to a version range based upon the date that the feature was added to BCD with the intent of replacing `true` values with ranged values to eliminate `true` values from BCD.

Commit/PR Adding the Feature: mdn#8830
@github-actions github-actions bot added the data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Sep 25, 2024
@@ -161,7 +161,7 @@
"__compat": {
"support": {
"chrome": {
"version_added": true
"version_added": "18"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is based on the actual version when the privacy API was moved out of the experimental status.

@@ -220,7 +220,7 @@
"__compat": {
"support": {
"chrome": {
"version_added": true
"version_added": "18"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is based on the actual version when the privacy API was moved out of the experimental status.

@danielhjacobs
Copy link
Contributor Author

Requesting review from @Rob--W and/or @dotproto

@queengooborg queengooborg added the KR: Real BCD 🔑 Key Result: Eliminate true/null values and replace them with "real" values. label Sep 26, 2024
webextensions/api/privacy.json Outdated Show resolved Hide resolved
Despite it being added to the compatibility data in mdn#8830, in reality it does not exist on Chromium browsers.

Co-authored-by: Rob Wu <[email protected]>
@queengooborg queengooborg merged commit 1bce102 into mdn:main Oct 1, 2024
6 checks passed
@danielhjacobs danielhjacobs deleted the patch-2 branch October 1, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions KR: Real BCD 🔑 Key Result: Eliminate true/null values and replace them with "real" values.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants