Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bcd): explain features with unknown earliest release version #11530

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

gagan-bhullar-tech
Copy link

@gagan-bhullar-tech gagan-bhullar-tech commented Jul 24, 2024

Summary

Fixes #11257

Problem

Explained in the linked issue

Solution

Renders the text

Yes
Full support (earliest supporting release version unknown)


Screenshots

Before

image

After

image

How did you test this change?

@gagan-bhullar-tech gagan-bhullar-tech requested a review from a team as a code owner July 24, 2024 05:03
@gagan-bhullar-tech gagan-bhullar-tech changed the title Explain yes compatibility mode fix: explain yes compatibility mode Jul 24, 2024
@caugner caugner changed the title fix: explain yes compatibility mode fix(bcd): explain yes compatibility mode Jul 24, 2024
@caugner
Copy link
Contributor

caugner commented Jul 25, 2024

@gagan-bhullar-tech Could you please add before/after screenshots? 🙏

@gagan-bhullar-tech
Copy link
Author

gagan-bhullar-tech commented Jul 25, 2024

@caugner

Before

image

After

image

@caugner
Copy link
Contributor

caugner commented Aug 9, 2024

@danielhjacobs Could you please take another look? 🙏

@danielhjacobs
Copy link
Contributor

I'm not actually able to display some yari pages properly right now and I'm not sure why. The CSS and JS files are being served as HTML:

The stylesheet http://localhost:3000/static/css/main.debc7a6f.css was not loaded because its MIME type, “text/html”, is not “text/css”.
Uncaught SyntaxError: expected expression, got '<'

Screenshot from 2024-08-09 10-32-08

@danielhjacobs
Copy link
Contributor

danielhjacobs commented Aug 9, 2024

Also worth noting, @queengooborg is making a concerted effort to remove all instances of true from the BCD, so this PR will only be useful for probably less than a month before that effort is finished.

There are 30 remaining files, all either webextensions.api or webextensions.manifest: https://github.com/search?q=repo%3Amdn%2Fbrowser-compat-data+%22%5C%22version_added%5C%22%3A+true%22&type=code (most were actually just updated, but some true values seem to have been missed).

@danielhjacobs
Copy link
Contributor

Ah I see:

#4654

Unfortunately, many of the pages that reproduce this issue are there.

Copy link
Contributor

@danielhjacobs danielhjacobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielhjacobs
Copy link
Contributor

danielhjacobs commented Aug 27, 2024

For reference, 8 files are left that would be affected by this PR, and that will reduce to 0 over time:

  1. https://github.com/mdn/browser-compat-data/blob/main/webextensions/api/commands.json - Chrome data, fixed by Update Chromium data for commands Web Extensions interface browser-compat-data#24263
  2. https://github.com/mdn/browser-compat-data/blob/main/webextensions/api/cookies.json - Chrome data, fixed by Update Chromium data for cookies Web Extensions interface browser-compat-data#24268
  3. https://github.com/mdn/browser-compat-data/blob/main/webextensions/api/management.json - Chrome data, fixed by Update Chromium data for management Web Extensions interface browser-compat-data#24278
  4. https://github.com/mdn/browser-compat-data/blob/main/webextensions/api/devtools.json - Chrome data, fixed by Update Chromium data for devtools Web Extensions interface browser-compat-data#24270
  5. https://github.com/mdn/browser-compat-data/blob/main/webextensions/manifest/background.json - Chrome data, fixed by Update Chromium data for webextensions.manifest.background.type browser-compat-data#24292
  6. https://github.com/mdn/browser-compat-data/blob/main/webextensions/manifest/optional_permissions.json - Chrome data, fixed by Update Chromium data for optional_permissions Web Extensions manifest property browser-compat-data#24093
  7. https://github.com/mdn/browser-compat-data/blob/main/webextensions/api/menus.json - Chrome data, fixed by Update Chromium data for menus Web Extensions interface browser-compat-data#24277
  8. https://github.com/mdn/browser-compat-data/blob/main/webextensions/manifest/commands.json - Chrome data, fixed by Update Chromium data for commands Web Extensions manifest property browser-compat-data#24293

@caugner caugner changed the title fix(bcd): explain yes compatibility mode fix(bcd): explain features with unknown earliest release version Sep 16, 2024
@github-actions github-actions bot added the idle label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Explain "Yes" in compatibility tables
3 participants