-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bcd): explain features with unknown earliest release version #11530
base: main
Are you sure you want to change the base?
fix(bcd): explain features with unknown earliest release version #11530
Conversation
client/src/document/ingredients/browser-compatibility-table/feature-row.tsx
Outdated
Show resolved
Hide resolved
@gagan-bhullar-tech Could you please add before/after screenshots? 🙏 |
e0ed948
to
4a6259c
Compare
@danielhjacobs Could you please take another look? 🙏 |
I'm not actually able to display some yari pages properly right now and I'm not sure why. The CSS and JS files are being served as HTML: The stylesheet http://localhost:3000/static/css/main.debc7a6f.css was not loaded because its MIME type, “text/html”, is not “text/css”. |
Also worth noting, @queengooborg is making a concerted effort to remove all instances of There are 30 remaining files, all either webextensions.api or webextensions.manifest: https://github.com/search?q=repo%3Amdn%2Fbrowser-compat-data+%22%5C%22version_added%5C%22%3A+true%22&type=code (most were actually just updated, but some |
Ah I see: Unfortunately, many of the pages that reproduce this issue are there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested http://localhost:3000/en-US/docs/Mozilla/Add-ons/WebExtensions/API/events#browser_compatibility and http://localhost:5042/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/externally_connectable#browser_compatibility (it had to be that URL, :3000 doesn't work for the manifest pages) and this seems to work, and the code seems fine.
For reference, 2 files are left that would be affected by this PR, and that will reduce to 0 over time:
|
Summary
Fixes #11257
Problem
Explained in the linked issue
Solution
Renders the text
Yes
Full support (earliest supporting release version unknown)
Screenshots
Before
After
How did you test this change?