feat(iOS): Combined stop details - display scheduled trips #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaSimon
force-pushed
the
es-combined-stop-schedules
branch
2 times, most recently
from
174c214 to
e47f71d
Compare
shared/src/commonMain/kotlin/com/mbta/tid/mbta_app/model/LoadingPlaceholders.kt
Outdated
Show resolved
Hide resolved
iosApp/iosApp/Pages/StopDetails/StopDetailsFilteredDepartureDetails.swift
Outdated
Show resolved
Hide resolved
This makes it easier to make the changes for the future first stop behavior when we need to do things more complicated than checking if the vehicle exists, and ensures it can never break the existing trip details page.
EmmaSimon
force-pushed
the
es-combined-stop-schedules
branch
from
e47f71d to
856b89c
Compare
EmmaSimon
force-pushed
the
es-combined-stop-schedules
branch
from
856b89c to
548a5e1
Compare
2 tasks
boringcactus
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Combined Stop + Trip Details: Show trip details when there's no predicted vehicle
Stacked onto #599
Display trip schedules if no vehicle or predictions exist. For any non-ferry trips, also allow tapping on the trip card to open an explainer cover that shows some text explaining the state.
iOS
android
- [ ] All user-facing strings added to strings resourceTesting
Updated existing tests, added new tests for new behavior.