feat(iOS): Combined stop separated vehicle UI #606
Conversation
There was a problem hiding this comment.
There's some logic in here that should probably move to the shared code by the time we start working on this page in Android, but it's faster to iterate on changes purely within the iOS side, and it might make more sense to move logic for this page into the shared code all at once after we've had it in people's hands for long enough to be confident it's all correct, so I'm fine if we don't deal with that yet now.
There was a problem hiding this comment.
I think I'd rather have these icons set to template mode and rendered in the route's text color than have these always rendered in the same color. I think the only difference would be in Silver Line bus routes, but that seems worth it to me.
There was a problem hiding this comment.
I forgot about SL and was thinking that these colors would always be correct, thanks, fixed!
| header | ||
| VStack(alignment: .leading, spacing: 24) { | ||
| explanationHeadline.font(Typography.title2Bold) | ||
| explanationImage |
There was a problem hiding this comment.
Should the explanationImage be marked as accessibilityHidden(true)?
Implements UI for the states when a trip has some predictions but is missing a vehicle and when the vehicle assigned to the prediction is finishing a different trip, since they have basically the same UI.
EmmaSimon
force-pushed
the
es-combined-prediction-missing-vehicle
branch
from
3714bea to
e03f2d7
Compare
Yeah that's a good point, I think for now I'll leave it in iOS until the behavior is more settled. |
Summary
Ticket: Show trip details when there's no predicted vehicle, Handle vehicle "on another trip"
Stacked onto #601
Add the UI for the trip states where a vehicle is finishing a different trip, or where some predictions for the trip exist but there is no assigned vehicle. Also includes explainers for both of these states that you can tap on the trip card to open.
iOS
android
- [ ] All user-facing strings added to strings resourceTesting
Added unit tests for the updated behavior