refactor: Convert itinerary legs to segments for easier rendering #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itinerary_detail /> doesn't have to think about them
joshlarson
commented
Dec 11, 2024
| @@ -0,0 +1,37 @@ | |||
| defmodule DotcomWeb.Components.TripPlanner.LegToSegmentHelper do | |||
There was a problem hiding this comment.
I'm not sold on either this name or this location for this file, but I couldn't think of a better one off the top of my head.
There was a problem hiding this comment.
Since it's not technically a rendered component, you can move this to the Dotcom.TripPlan. namespace. I don't mind the current name.
thecristen
requested changes
Dec 11, 2024
|
@thecristen I think I addressed everything - want to take another look? |
thecristen
reviewed
Dec 11, 2024
lib/dotcom/trip_plan/input_form.ex
Outdated
| @@ -49,6 +49,7 @@ defmodule Dotcom.TripPlan.InputForm do | |||
| date: PlanParams.to_date_param(datetime), | |||
| time: PlanParams.to_time_param(datetime), | |||
| transportModes: __MODULE__.Modes.selected_mode_keys(modes) |> PlanParams.to_modes_param(), | |||
| numItineraries: 40, | |||
There was a problem hiding this comment.
I kinda wanna let this slide, but 40 seems kinda excessive?
There was a problem hiding this comment.
Oh oops - didn't mean to include this change. I've been using that to get more itineraries so that the one I'm looking for is more likely to actually show up.
thecristen
approved these changes
Dec 11, 2024
joshlarson
deleted the
jdl/refactor/convert-itinerary-legs-to-segments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactor.
No ticket.
The point of this refactor is that the data returned from OpenTripPlanner is subtly different from what we want to render on the screen. Even in a simple case, when OTP returns
[walking, transit, walking], what we actually want to draw on the screen is[location, walking, transit, walking, location]*, and there are some corner-cases that make this even more complicated.*I'm making the assumption that drawing
transiton the screen actually means drawing the transit leg's start location and end location, each with the right icon for that transit leg, on either side of the transit leg details itself. This works out, since all transit legs are bracketed by locations indicating their stops or stations.This'll enable follow-ups to address two use cases:
[transit, walking, transit]or something like that, where the first or last leg of an itinerary is transit, then we want to draw[transit, walking, transit]- in other words, we don't want to showlocationright next to transit. Ticket for this, which includes a screenshot of what it looks like now.[walking, transit, transit, walking], that is, when there's a transfer that involves no walking, then we want to add in a "waiting leg", so the end result should be[location, walking, transit, waiting, transit, walking, location]. Ticket for this (same deal - has a screenshot).