Migrate RT1 to mbodied-agents #6
Open
+1,786
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nqyy
requested changes
Jun 7, 2024
| @@ -64,32 +64,32 @@ class Pose6D(Motion): | |||
|
|
|||
| x: float = MotionField( | |||
| default_factory=lambda: 0.0, | |||
| bounds=[-1, 1], | |||
| bounds=None, | |||
There was a problem hiding this comment.
Why are these bounds changed to None
There was a problem hiding this comment.
@sebbyjp asked me to make them None
| from mbodied_agents.types.controls import Motion | ||
|
|
||
|
|
||
| class MotorAgent(ABC): |
There was a problem hiding this comment.
Let's call it MotionAgent. Also rename the directory.
There was a problem hiding this comment.
Initially it was MotionAgent. @sebbyjp suggested MotorAgent
| @@ -0,0 +1,187 @@ | |||
| from collections import OrderedDict | |||
There was a problem hiding this comment.
Add the common MbodiAI header above. Also for other new files.
nqyy
force-pushed
the
main
branch
4 times, most recently
from
bacecb7
to
012a519
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Bare Minimum Requirements for
rt1Description
This update introduces the bare minimum requirements for
rt1. The current implementation includes a dummy sample to test the network functionality. The training part is not included in this update.Summary:
rt1.Related Issue
If there are related issues or tasks, they are listed below. If there are none, this section may be omitted.
Related Issue:
How Has This Been Tested?
The changes have been verified by running a dummy sample to ensure the network functionality works as expected.
Testing:
Checklist