Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➕ Re-add beautifulsoup4 to deps #1163

Merged
merged 1 commit into from
Apr 18, 2024
+54 −19
Merged

➕ Re-add beautifulsoup4 to deps #1163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions requirements/base.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ uwsgi
sentry-sdk # error monitoring
elastic-apm # Elastic APM integration

beautifulsoup4

# DigidLocal
django-digid-eherkenning
maykin-python3-saml
Expand Down
18 changes: 14 additions & 4 deletions requirements/base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ attrs==21.2.0
# via
# glom
# jsonschema
beautifulsoup4==4.12.3
# via -r requirements/base.in
billiard==3.6.4.0
# via celery
boltons==21.0.0
Expand Down Expand Up @@ -61,6 +63,7 @@ confusable-homoglyphs==3.2.0
# via django-registration
cryptography==41.0.7
# via
# django-digid-eherkenning
# django-simple-certmanager
# josepy
# mozilla-django-oidc
Expand All @@ -75,10 +78,7 @@ cssselect2==0.4.1
# svglib
# weasyprint
defusedxml==0.7.1
# via
# django-digid-eherkenning
# maykin-python3-saml
# odfpy
# via odfpy
diff-match-patch==20200713
# via django-import-export
django==4.2.11
Expand Down Expand Up @@ -462,6 +462,7 @@ pyyaml==6.0
# via
# drf-spectacular
# gemma-zds-client
# responses
# tablib
qrcode==6.1
# via django-two-factor-auth
Expand All @@ -481,7 +482,13 @@ requests==2.31.0
# maykin-python3-saml
# messagebird
# mozilla-django-oidc
# requests-mock
# responses
# zgw-consumers
requests-mock==1.12.1
# via maykin-python3-saml
responses==0.25.0
# via maykin-python3-saml
Comment on lines +488 to +491
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why these are added now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment in main thread.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my bad

sentry-sdk==1.38.0
# via -r requirements/base.in
six==1.16.0
Expand All @@ -495,6 +502,8 @@ six==1.16.0
# orderedmultidict
# python-dateutil
# qrcode
soupsieve==2.5
# via beautifulsoup4
sqlparse==0.4.4
# via django
svglib==1.5.1
Expand Down Expand Up @@ -523,6 +532,7 @@ urllib3==1.26.18
# elastic-apm
# elasticsearch
# requests
# responses
# sentry-sdk
uwsgi==2.0.23
# via -r requirements/base.in
Expand Down
34 changes: 25 additions & 9 deletions requirements/ci.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,11 @@ attrs==21.2.0
# jsonschema
autoflake==2.3.0
# via -r requirements/test-tools.in
beautifulsoup4==4.10.0
# via webtest
beautifulsoup4==4.12.3
# via
# -c requirements/base.txt
# -r requirements/base.txt
# webtest
billiard==3.6.4.0
# via
# -c requirements/base.txt
Expand Down Expand Up @@ -128,6 +131,7 @@ cryptography==41.0.7
# via
# -c requirements/base.txt
# -r requirements/base.txt
# django-digid-eherkenning
# django-simple-certmanager
# josepy
# mozilla-django-oidc
Expand All @@ -150,8 +154,6 @@ defusedxml==0.7.1
# via
# -c requirements/base.txt
# -r requirements/base.txt
# django-digid-eherkenning
# maykin-python3-saml
# odfpy
diff-match-patch==20200713
# via
Expand Down Expand Up @@ -858,6 +860,7 @@ pyyaml==6.0
# -r requirements/base.txt
# drf-spectacular
# gemma-zds-client
# responses
# tablib
qrcode==6.1
# via
Expand Down Expand Up @@ -888,9 +891,19 @@ requests==2.31.0
# messagebird
# mozilla-django-oidc
# requests-mock
# responses
# zgw-consumers
requests-mock==1.9.3
# via -r requirements/test-tools.in
requests-mock==1.12.1
# via
# -c requirements/base.txt
# -r requirements/base.txt
# -r requirements/test-tools.in
# maykin-python3-saml
responses==0.25.0
# via
# -c requirements/base.txt
# -r requirements/base.txt
# maykin-python3-saml
sentry-sdk==1.38.0
# via
# -c requirements/base.txt
Expand All @@ -908,9 +921,11 @@ six==1.16.0
# orderedmultidict
# python-dateutil
# qrcode
# requests-mock
soupsieve==2.3.1
# via beautifulsoup4
soupsieve==2.5
# via
# -c requirements/base.txt
# -r requirements/base.txt
# beautifulsoup4
sqlparse==0.4.4
# via
# -c requirements/base.txt
Expand Down Expand Up @@ -961,6 +976,7 @@ urllib3==1.26.18
# elastic-apm
# elasticsearch
# requests
# responses
# sentry-sdk
uwsgi==2.0.23
# via
Expand Down
19 changes: 13 additions & 6 deletions requirements/dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ babel==2.9.1
# via sphinx
bandit==1.7.4
# via -r requirements/dev.in
beautifulsoup4==4.10.0
beautifulsoup4==4.12.3
# via
# -c requirements/ci.txt
# -r requirements/ci.txt
Expand Down Expand Up @@ -158,6 +158,7 @@ cryptography==41.0.7
# via
# -c requirements/ci.txt
# -r requirements/ci.txt
# django-digid-eherkenning
# django-simple-certmanager
# josepy
# mozilla-django-oidc
Expand All @@ -183,8 +184,6 @@ defusedxml==0.7.1
# via
# -c requirements/ci.txt
# -r requirements/ci.txt
# django-digid-eherkenning
# maykin-python3-saml
# odfpy
diff-match-patch==20200713
# via
Expand Down Expand Up @@ -996,6 +995,7 @@ pyyaml==6.0
# bandit
# drf-spectacular
# gemma-zds-client
# responses
# tablib
pyzmq==25.1.2
# via locust
Expand Down Expand Up @@ -1029,12 +1029,19 @@ requests==2.31.0
# messagebird
# mozilla-django-oidc
# requests-mock
# responses
# sphinx
# zgw-consumers
requests-mock==1.9.3
requests-mock==1.12.1
# via
# -c requirements/ci.txt
# -r requirements/ci.txt
# maykin-python3-saml
responses==0.25.0
# via
# -c requirements/ci.txt
# -r requirements/ci.txt
# maykin-python3-saml
roundrobin==0.0.4
# via locust
sentry-sdk==1.38.0
Expand All @@ -1055,12 +1062,11 @@ six==1.16.0
# orderedmultidict
# python-dateutil
# qrcode
# requests-mock
smmap==5.0.0
# via gitdb
snowballstemmer==2.1.0
# via sphinx
soupsieve==2.3.1
soupsieve==2.5
# via
# -c requirements/ci.txt
# -r requirements/ci.txt
Expand Down Expand Up @@ -1149,6 +1155,7 @@ urllib3==1.26.18
# elastic-apm
# elasticsearch
# requests
# responses
# sentry-sdk
uwsgi==2.0.23
# via
Expand Down
Loading