Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

➕ Re-add beautifulsoup4 to deps #1163

Merged
merged 1 commit into from
Apr 18, 2024
Merged

➕ Re-add beautifulsoup4 to deps #1163

merged 1 commit into from
Apr 18, 2024

Conversation

stevenbal
Copy link
Contributor

this was previously removed, but it was still in use

@stevenbal stevenbal requested a review from alextreme April 18, 2024 09:03
@stevenbal stevenbal force-pushed the fix/add-beautifulsoup4 branch from 78f47b4 to b587781 Compare April 18, 2024 09:25
@stevenbal stevenbal marked this pull request as draft April 18, 2024 09:26
@stevenbal
➕ Re-add beautifulsoup4 to deps
7a71dbe 
this was previously removed, but it was still in use
@stevenbal stevenbal force-pushed the fix/add-beautifulsoup4 branch from b587781 to 7a71dbe Compare April 18, 2024 09:34
stevenbal
stevenbal commented Apr 18, 2024
View reviewed changes
requirements/base.txt
Comment on lines +488 to +491
requests-mock==1.12.1
# via maykin-python3-saml
responses==0.25.0
# via maykin-python3-saml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why these are added now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment in main thread.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my bad

@stevenbal stevenbal marked this pull request as ready for review April 18, 2024 09:35
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.05%. Comparing base (1490208) to head (b587781).
Report is 11 commits behind head on develop.

❗ Current head b587781 differs from pull request most recent head 7a71dbe. Consider uploading reports for the commit 7a71dbe to get more accurate results

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1163   +/-   ##
========================================
  Coverage    95.05%   95.05%           
========================================
  Files          950      950           
  Lines        33789    33789           
========================================
  Hits         32118    32118           
  Misses        1671     1671

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alextreme alextreme requested review from Bartvaderkin and pi-sigma and removed request for alextreme April 18, 2024 11:20
@Bartvaderkin
Copy link
Contributor

We looked at the mystery changes but they appear now because Alex didn't recompile after a manual saml/eherkenning update, and have some test dependencies because it looks like saml includes those.

@alextreme alextreme merged commit 8a8eb34 into develop Apr 18, 2024
17 checks passed
@alextreme alextreme deleted the fix/add-beautifulsoup4 branch April 18, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextreme alextreme alextreme left review comments

@Bartvaderkin Bartvaderkin Bartvaderkin approved these changes

@pi-sigma pi-sigma Awaiting requested review from pi-sigma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevenbal @codecov-commenter @Bartvaderkin @alextreme