Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2259] Show case result in list view #1160

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Conversation

Bartvaderkin
Copy link
Contributor

@Bartvaderkin Bartvaderkin commented Apr 16, 2024

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 97.56098% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.05%. Comparing base (a47782f) to head (3e33249).
Report is 13 commits behind head on develop.

Files Patch % Lines
src/open_inwoner/utils/glom.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1160   +/-   ##
========================================
  Coverage    95.05%   95.05%           
========================================
  Files          950      952    +2     
  Lines        33790    33824   +34     
========================================
+ Hits         32119    32152   +33     
- Misses        1671     1672    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bartvaderkin Bartvaderkin requested a review from pi-sigma April 18, 2024 07:04
@Bartvaderkin Bartvaderkin marked this pull request as ready for review April 18, 2024 07:04
from .models import ZaakTypeConfig, ZaakTypeStatusTypeConfig
from .utils import is_zaak_visible

logger = logging.getLogger(__name__)


def resolve_zaak_type(case: Zaak, client=None) -> None:
def resolve_zaak_type(case: Zaak, client: CatalogiClient = None) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client: CatalogiClient | None = None

Similarly for the other annotations

src/open_inwoner/utils/glom.py Outdated Show resolved Hide resolved
@pi-sigma
Copy link
Contributor

I double-checked by changing statuses/results on the E-suite and now I'm not sure it's working as intended. On the list view, the result is shown instead of the status, but the detail view still displays the status

E-suite:

esuite

List:

list

Detail:

detail

@Bartvaderkin
Copy link
Contributor Author

Bartvaderkin commented Apr 18, 2024

The ticket was to change the list to replace the status of a closed case with the same value as the result on the detail page.

I didn't change anything on the detail page.

@pi-sigma
Copy link
Contributor

Let's discuss next week and create a separate ticket for the detail view, if necessary, then we can merge this. Unless @alextreme thinks otherwise.

@alextreme
Copy link
Member

@pi-sigma good comment, I've updated the user story 2208. The change is as requested so we'll leave it at this due to the lack of remaining time in this sprint

@alextreme alextreme merged commit 8e638a5 into develop Apr 18, 2024
15 checks passed
@alextreme alextreme deleted the feature/2259-cases-result branch April 18, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants