Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2260] Removed StatusTranslation model #1142

Merged
merged 3 commits into from
Apr 22, 2024
Merged

[#2260] Removed StatusTranslation model #1142

merged 3 commits into from
Apr 22, 2024

Conversation

Bartvaderkin
Copy link
Contributor

No description provided.

@Bartvaderkin Bartvaderkin force-pushed the feature/2260-remove-status-translation branch 2 times, most recently from d9c642b to 6b68d92 Compare April 12, 2024 07:35
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.05%. Comparing base (8e638a5) to head (f5151ac).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1142      +/-   ##
===========================================
- Coverage    95.07%   95.05%   -0.02%     
===========================================
  Files          955      953       -2     
  Lines        33961    33835     -126     
===========================================
- Hits         32288    32162     -126     
  Misses        1673     1673

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bartvaderkin Bartvaderkin marked this pull request as ready for review April 12, 2024 09:13
@Bartvaderkin Bartvaderkin requested a review from pi-sigma April 12, 2024 09:13
pi-sigma
pi-sigma requested changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! Couple minor questions.

src/open_inwoner/openzaak/api_models.py Outdated Show resolved Hide resolved
src/open_inwoner/openzaak/tests/test_notification_utils.py Outdated Show resolved Hide resolved
src/open_inwoner/userfeed/tests/hooks/test_case_status.py Outdated Show resolved Hide resolved
@alextreme
Copy link
Member

Discussed with Groningen, and to ease the transition I'm delaying this PR until 1.17

@Bartvaderkin Bartvaderkin force-pushed the feature/2260-remove-status-translation branch from 86766ae to cd46900 Compare April 18, 2024 08:25
@Bartvaderkin
Copy link
Contributor Author

Bartvaderkin commented Apr 18, 2024 •
edited
Loading

This will have to be rebased on #1160's as it touches same code (the bits using glom_multiple) its been rebased

@Bartvaderkin Bartvaderkin requested a review from pi-sigma April 18, 2024 08:28
@Bartvaderkin Bartvaderkin force-pushed the feature/2260-remove-status-translation branch from cd46900 to f5151ac Compare April 19, 2024 07:10
@alextreme alextreme merged commit 1843e1d into develop Apr 22, 2024
15 checks passed
@alextreme alextreme deleted the feature/2260-remove-status-translation branch April 22, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi-sigma pi-sigma pi-sigma approved these changes

Assignees
No one assigned
Labels
release 1.17
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bartvaderkin @codecov-commenter @alextreme @pi-sigma