Skip to content

feat(pinned events): persist the pinned events timeline#6085

Open
bnjbvr wants to merge 12 commits intomainfrom
bnjbvr/pinned-events-linked-chunk
Open

feat(pinned events): persist the pinned events timeline#6085
bnjbvr wants to merge 12 commits intomainfrom
bnjbvr/pinned-events-linked-chunk

Conversation

@bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Jan 29, 2026

This brings some nice benefits:

  • reloading the previous list of pinned events from storage, which gives us…
  • …offline access for pinned events
  • better support for automatic redecryption of pinned events

Part of #5954.

@bnjbvr bnjbvr force-pushed the bnjbvr/pinned-events-linked-chunk branch from d6a6eed to 046adb4 Compare February 2, 2026 17:20
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 2, 2026

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing bnjbvr/pinned-events-linked-chunk (7f1f465) with main (52014dc)

Open in CodSpeed

@bnjbvr bnjbvr force-pushed the bnjbvr/pinned-events-linked-chunk branch 2 times, most recently from 82df963 to eb4cc51 Compare February 4, 2026 10:57
@bnjbvr bnjbvr force-pushed the bnjbvr/pinned-events-linked-chunk branch from eb4cc51 to fb23758 Compare February 4, 2026 18:18
@bnjbvr bnjbvr force-pushed the bnjbvr/pinned-events-linked-chunk branch from fb23758 to 7f1f465 Compare February 4, 2026 18:24
@bnjbvr bnjbvr marked this pull request as ready for review February 4, 2026 18:24
@bnjbvr bnjbvr requested a review from a team as a code owner February 4, 2026 18:24
@bnjbvr bnjbvr requested review from stefanceriu and removed request for a team February 4, 2026 18:24
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 78.58770% with 94 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.78%. Comparing base (70dd020) to head (7f1f465).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/matrix-sdk/src/event_cache/room/pinned_events.rs 74.93% 64 Missing and 26 partials ⚠️
crates/matrix-sdk/src/event_cache/room/mod.rs 89.65% 0 Missing and 3 partials ⚠️
...rates/matrix-sdk-ui/src/timeline/controller/mod.rs 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6085      +/-   ##
==========================================
- Coverage   89.84%   89.78%   -0.07%     
==========================================
  Files         363      363              
  Lines      100656   100973     +317     
  Branches   100656   100973     +317     
==========================================
+ Hits        90439    90655     +216     
- Misses       6691     6762      +71     
- Partials     3526     3556      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant