Skip to content

Conversation

@bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Feb 3, 2026

The method is kept on the pinned loader trait at the moment, because it's too inconvenient to remove it quite yet. This will happen in a subsequent PR.

Part of #5954. Prerequisite for #6085.

… the `Room` object

The method is kept on the pinned loader trait at the moment, because
it's too inconvenient to remove it quite yet. This will happen in a
subsequent PR.
@bnjbvr bnjbvr requested a review from a team as a code owner February 3, 2026 16:39
@bnjbvr bnjbvr requested review from stefanceriu and removed request for a team February 3, 2026 16:39
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 88.23529% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.83%. Comparing base (40c6c33) to head (93a0ebc).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk/src/room/mod.rs 86.95% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6108      +/-   ##
==========================================
- Coverage   89.84%   89.83%   -0.01%     
==========================================
  Files         363      363              
  Lines      100638   100656      +18     
  Branches   100638   100656      +18     
==========================================
+ Hits        90420    90429       +9     
- Misses       6690     6702      +12     
+ Partials     3528     3525       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 3, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing bnjbvr/load-event-with-relations (93a0ebc) with main (40c6c33)

Summary

✅ 50 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants