Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circle2D intersection with Line(Segment)2D #237

Merged
merged 25 commits into from
Dec 9, 2023
Merged

Circle2D intersection with Line(Segment)2D #237

merged 25 commits into from
Dec 9, 2023

Commits on Nov 23, 2023

  1. Feat: Line2D.DistanceTo(point)

    @f-frhs
    f-frhs committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    0a2521d View commit details
    Browse the repository at this point in the history

  2. feat: Circle2D.IntersectWith(Line2D)

    @f-frhs
    f-frhs committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    c3ad590 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. doc: fix xml comment

    @f-frhs
    f-frhs committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    037d3c5 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2023

  1. refactor: extract the private method findParameterTs(Line2D) 

    Aleady existing test cases must be changed because of the implementation of FindRoots.Polynomial(coeffs), that is, the order of the solutions.
    @f-frhs
    f-frhs committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    fb0314b View commit details
    Browse the repository at this point in the history

  2. feat: Circle2D.IntersectWith(LineSegment2D)

    @f-frhs
    f-frhs committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    baf6605 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. doc: fix the variable-name list in comment

    @f-frhs
    f-frhs committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    c2612b6 View commit details
    Browse the repository at this point in the history

  2. fix: a typo

    @f-frhs
    f-frhs committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    4685302 View commit details
    Browse the repository at this point in the history

  3. change: use the fact that dot-product of the unit vector is always 1.0

    @f-frhs
    f-frhs committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    f3e4731 View commit details
    Browse the repository at this point in the history

  4. Revert "Feat: Line2D.DistanceTo(point)" 

    This reverts commit 0a2521d.
    @f-frhs
    f-frhs committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    847cdaf View commit details
    Browse the repository at this point in the history

  5. remove: src/Spatial/Extensions/DoubleExtensions.cs

    @f-frhs
    f-frhs committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    2d222ac View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. doc: revise xml comments

    @f-frhs
    f-frhs committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    571cf7d View commit details
    Browse the repository at this point in the history

  2. fix a typo

    @f-frhs
    f-frhs committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    9e33c1b View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2023

  1. test: fix testcases to test number of intersections

    @f-frhs
    f-frhs committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    7c5df6a View commit details
    Browse the repository at this point in the history

  2. fix: IntersectionWith() to return a single point when a line tangent … 

    …to the circle
    @f-frhs
    f-frhs committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    1a527b1 View commit details
    Browse the repository at this point in the history

  3. test: Add tests for intersection of Circle and LineSegment2D 

    for the case where LineSegment contains some of obtained intersections.
    @f-frhs
    f-frhs committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    b27fdb1 View commit details
    Browse the repository at this point in the history

  4. test: add TODO comment

    @f-frhs
    f-frhs committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    dc7ea85 View commit details
    Browse the repository at this point in the history

  5. refactor: rename line to segment

    @f-frhs
    f-frhs committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    5930b12 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. fix: type declaration (from 1d to 1.0)

    @f-frhs
    f-frhs committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    0e7eb69 View commit details
    Browse the repository at this point in the history

  2. test: fix testcases to use expected points

    @f-frhs
    f-frhs committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    5c3cd70 View commit details
    Browse the repository at this point in the history

  3. test: fix testcases to use expected points

    @f-frhs
    f-frhs committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    ab59a23 View commit details
    Browse the repository at this point in the history

  4. test: add testcases where the line is parallel to the Y-axis

    @f-frhs
    f-frhs committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    451a87d View commit details
    Browse the repository at this point in the history

  5. test: add testcases parallel to Y-axis and general cases

    @f-frhs
    f-frhs committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    3d3748b View commit details
    Browse the repository at this point in the history

  6. test: add testcases for Intersection of Circle2D with LIneSegment2D 

    - parallel to X-axis
- parallel to Y-axis
- general cases (eg. x-y+c=0)

test: rename method's name
    @f-frhs
    f-frhs committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    6b8c3db View commit details
    Browse the repository at this point in the history

  7. test: replace +01 to +1

    @f-frhs
    f-frhs committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    f3815ed View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2023

  1. Minor changes in test

    @jkalias
    jkalias committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    acccdbf View commit details
    Browse the repository at this point in the history