Circle2D intersection with Line(Segment)2D #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aleady existing test cases must be changed because of the implementation of FindRoots.Polynomial(coeffs), that is, the order of the solutions.
jkalias
requested changes
Nov 27, 2023
jkalias
requested changes
Nov 29, 2023
jkalias
requested changes
Nov 30, 2023
jkalias
reviewed
Dec 1, 2023
src/Spatial/Euclidean/Circle2D.cs
Outdated
| var d = line.Direction; | ||
| var r = this.Radius; | ||
|
|
||
| var a = 1d; |
There was a problem hiding this comment.
Could you tell me what the difference is between var a = 1.0 and var a = 1d?
If this repo has coding conventions, I failed to read the doc. I will read it and fix this.
Thanks for the comment.
There was a problem hiding this comment.
I feel that var a = 1d; is a bit like C of Fortran, that's all. I wouldn't reject a PR based on this.
There was a problem hiding this comment.
Thanks for the comment.
I respect your feeling, and I will fix this.
There was a problem hiding this comment.
done in the commit f-frhs@0e7eb69
for the case where LineSegment contains some of obtained intersections.
jkalias
reviewed
Dec 3, 2023
jkalias
reviewed
Dec 3, 2023
jkalias
reviewed
Dec 3, 2023
jkalias
reviewed
Dec 3, 2023
- parallel to X-axis - parallel to Y-axis - general cases (eg. x-y+c=0) test: rename method's name
f-frhs
force-pushed
the
Circle2D_Intersection
branch
from
4081b03
to
f3815ed
Compare
|
Could you tell me which requrest remains? |
|
Thank you for your effort and time! |
|
Thank YOU for your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the code to calculate the intersection of the circle with the line, specifically,
It will be nice if we can discuss whether the testcases are sufficient or not.
this task is based on the comment in #186:
Originally posted by @jkalias in #186 (comment)