New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9 and handle including resources from local/git deps #30

Closed

xfthhxk wants to merge 1 commit into luchiniatwork:master from xfthhxk:9-uberjar-git-local-deps

Contributor

xfthhxk commented Dec 14, 2019

Opening this PR in place of #10 since a bunch of other commits got included there.

This change separates out mvn deps from git and local deps.
mvn deps continue to be processed as before.
git/local deps are excluded to avoid the error described in uberjar fails when using git libs #9
uberjar also includes resources from git/local deps that are skipped by previous steps.
Resources might include things like .sql, .edn etc files that exist in the git/local deps that are needed in the uberjar.


          Fix #9 and handle including resources from local/git deps

c8a0147

xfthhxk mentioned this pull request

filter on :mvn manifest when getting dep jars to fix #9 #10

Closed

alza-bitz commented Oct 3, 2020

@luchiniatwork is there any chance this could be merged in? Would really like the fix for #9 🙏🙂

xfthhxk closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet