filter on :mvn manifest when getting dep jars to fix #9 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance of seeing this merged? I'm affected by issue #11. My Edit: Thanks for putting this together by the way. |
|
@xfthhxk this is great stuff. It seems that the commits are covering lots of issues though and not just the one reported here. Could you extract the code for the fix? |
|
@xfthhxk something else I would like to understand here is are we skipping these dependencies or adding them in? Whichever way, it would be great to document it too! |
|
Closing this PR in favor of #30. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that only paths to jar files are returned by
get-dep-jars. This addresses issue #9.