Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #518: lsquic compliance with RFC 9000 for MAX_STREAM_DATA frame #525

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Fixes #518: lsquic compliance with RFC 9000 for MAX_STREAM_DATA frame #525

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
048c05e
Fix lsquic compliance with RFC 9000 for MAX_STREAM_DATA frame
plumplumli Dec 26, 2024
ff2e540
Fix lsquic compliance with RFC 9000 for MAX_STREAM_DATA frame, and bu…
plumplumli Dec 26, 2024
a91840a
Fix: handle MAX_STREAM_DATA frame according to RFC 9000 and RFC 9114
plumplumli Jan 3, 2025
662f437
Fix: Readjust to handle MAX_STREAM_DATA frame according to RFC 9000 a…
plumplumli Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 53 additions & 3 deletions src/liblsquic/lsquic_full_conn_ietf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6186,6 +6186,21 @@ process_max_stream_data_frame (struct ietf_full_conn *conn,
return 0;
}

if ((conn->ifc_flags & (IFC_SERVER|IFC_HTTP)) == IFC_HTTP
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to move those two tests under if (is_peer_initiated(conn, stream_id)), just in case side effects for regular MAX_STREAM_DATA processing.

&& SIT_BIDI_SERVER == (stream_id & SIT_MASK))
{
ABORT_QUIETLY(1, HEC_STREAM_CREATION_ERROR, "HTTP/3 server "
"is not allowed to initiate bidirectional streams (got "
"STREAM frame for stream %"PRIu64, stream_id);
return 0;
}

if (conn->ifc_flags & IFC_CLOSING)
{
LSQ_DEBUG("Connection closing: ignore frame");
return parsed_len;
}

stream = find_stream_by_id(conn, stream_id);
if (stream)
lsquic_stream_window_update(stream, max_data);
Expand All @@ -6194,9 +6209,44 @@ process_max_stream_data_frame (struct ietf_full_conn *conn,
stream_id);
else
{
ABORT_QUIETLY(0, TEC_STREAM_STATE_ERROR, "received MAX_STREAM_DATA "
"frame on never-opened stream %"PRIu64, stream_id);
return 0;
if (is_peer_initiated(conn, stream_id))
{
const lsquic_stream_id_t max_allowed =
conn->ifc_max_allowed_stream_id[stream_id & SIT_MASK];
if (stream_id >= max_allowed)
{
ABORT_QUIETLY(0, TEC_STREAM_LIMIT_ERROR, "incoming stream "
"%"PRIu64" exceeds allowed max of %"PRIu64,
stream_id, max_allowed);
return 0;
}
if (conn->ifc_flags & IFC_GOING_AWAY)
{
LSQ_DEBUG("going away: reject new incoming stream %"PRIu64,
stream_id);
maybe_schedule_ss_for_stream(conn, stream_id,
HEC_REQUEST_REJECTED);
return parsed_len;
}
stream = new_stream(conn, stream_id, SCF_CALL_ON_NEW);
if (!stream)
{
ABORT_ERROR("cannot create new stream: %s", strerror(errno));
return 0;
}
if (SD_BIDI == ((stream_id >> SD_SHIFT) & 1)
&& (!valid_stream_id(conn->ifc_max_req_id)
|| conn->ifc_max_req_id < stream_id))
conn->ifc_max_req_id = stream_id;

lsquic_stream_window_update(stream, max_data);
}
else
{
ABORT_QUIETLY(0, TEC_STREAM_STATE_ERROR, "received MAX_STREAM_DATA "
"frame on never-opened stream %"PRIu64, stream_id);
return 0;
}
}

return parsed_len;
Expand Down