Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #518: lsquic compliance with RFC 9000 for MAX_STREAM_DATA frame #525

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

plumplumli
Copy link
Contributor

The story begins here:

#518.

The bug is:

The function process_max_stream_data_frame() returns an error if it detects that the corresponding stream has not been created, causing LSQUIC to close the connection.

According to RFC9000:

  1. If this stream is initiated by peer, the local side should create the receiving part of the stream and transition to the Recv state upon receiving a max_stream_data frame (similar to how process_stream_frame() handles it).
    状态机流程
    允许创建

  2. If this stream is initiated by local side, the local side should consider it as a connection error of type STREAM_STATE_ERROR.
    不允许创建

We submitted the solution according to RFC9000.

@litespeedtech
Copy link
Owner

Thanks!
There are a few issues with this patch.
Since it creates a new stream, more related validation logic similar to those in process_stream_frame() needed.

if ((conn->ifc_flags & (IFC_SERVER|IFC_HTTP)) == IFC_HTTP

if (conn->ifc_flags & IFC_CLOSING)

And after creating the stream, need to call lsquic_stream_window_update().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants