Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circleci: go get -u ... -> go install ...@latest #423

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

rminnich
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.63%. Comparing base (905be14) to head (452f4ab).
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
- Coverage   41.73%   41.63%   -0.11%     
==========================================
  Files         141      142       +1     
  Lines       10703    10729      +26     
==========================================
  Hits         4467     4467              
- Misses       5368     5394      +26     
  Partials      868      868              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rminnich
Copy link
Contributor Author

we need to remove golangci-lint usage. It's ignoring our go.mod version and flagging errors for newer go versions.

@rminnich
Copy link
Contributor Author

another problem -- our tests no longer pass :-(

This project needs some work.

@rminnich
Copy link
Contributor Author

I'm going to chump this in. It's fixing a CI problem.

@rminnich rminnich merged commit ef43a2a into linuxboot:main Sep 15, 2024
6 of 7 checks passed
@orangecms
Copy link
Collaborator

Yes, indeed, a good bunch of maintenance is necessary.

I'll be happy to help out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants