NewSignatureData works with generic crypto signer. #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
werwurm
force-pushed
the
generic_signer
branch
from
a286300
to
5fba968
Compare
Casting the crypto.Signer into concrete crypto.PrivateKey implementations unnecessarily limits the use of the library to software implementations provided by the golang crypto libraries. This patch makes the detection of the algorithm based on the public key which is exposed through crypto.Signer.Public() and then uses the interface function Sign to perform the actual signing. This allow for hiding the implementation behind the crypto.Signer interface, e.g., for signing with an HSM backed key. Caveat: This patch does not add support for generic SM2 implementations. But this is not a regression. Signed-off-by: Janis Danisevskis <[email protected]>
werwurm
force-pushed
the
generic_signer
branch
from
5fba968
to
4b57b14
Compare
This was referenced Sep 6, 2024
|
The clean-code error does not seam to be related to my PR. There seems to be an error while installing one of the checks? |
rminnich
approved these changes
Sep 15, 2024
rminnich
approved these changes
Sep 15, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
=======================================
Coverage 41.63% 41.63%
=======================================
Files 142 142
Lines 10729 10729
=======================================
Hits 4467 4467
Misses 5394 5394
Partials 868 868 ☔ View full report in Codecov by Sentry. |
Yes, #423 fixed part of the CI issues. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Casting the crypto.Signer into concrete crypto.PrivateKey
implementations unnecessarily limits the use of the library to software
implementations provided by the golang crypto libraries.
This patch makes the detection of the algorithm based on the public key
which is exposed through crypto.Signer.Public() and then uses the
interface function Sign to perform the actual signing.
This allows for hiding the implementation behind the crypto.Signer
interface, e.g., for signing with an HSM backed key.
Caveat: This patch does not add support for generic SM2 implementations.
But this is not a regression.
Signed-of-by: Janis Danisevskis [email protected]