Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce pod-to-pod communication outline for edge docs #1655

Merged
merged 9 commits into from
Aug 22, 2023

Conversation

mateiidavid
Copy link
Member

Still a work in progress

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be good to introduce both modes from the beginning, so users don't have to wait till way down the doc to discover about the p2p mode.

@@ -0,0 +1,91 @@
+++
title = "Multi-cluster communication in flat networks"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looking at this from the outside, it feels like this separate feature doc shouldn't exist, and any additional content should be rolled into the existing multicluster feature doc.

Signed-off-by: William Morgan <[email protected]>
@wmorgan
Copy link
Member

wmorgan commented Aug 20, 2023

I've updated these docs to my semi-satisfaction, including moving the second doc to the reference section where I think it was intended to be. There is some repetition between feature & reference docs which is not ideal but is palatable.

There is a section at the end of the reference doc about namespace sameness that I left in, but I think this is more confusing than helpful and I'm not sure what the actual implications are for users. Keep your control plane namespaces the same? I would like to remove this section but perhaps I'm missing somethign.

@wmorgan
Copy link
Member

wmorgan commented Aug 20, 2023

Also: there is still one reference that needs to be fixed once we have the URL.

@wmorgan wmorgan marked this pull request as ready for review August 22, 2023 14:05
@alpeb alpeb merged commit 81244fc into main Aug 22, 2023
7 checks passed
@alpeb alpeb deleted the matei/pod-to-pod-docs branch August 22, 2023 19:02
sourishkrout pushed a commit to stateful/linkerd-website that referenced this pull request Aug 23, 2023
* Introduce pod-to-pod communication outline for edge docs

Signed-off-by: Matei David <[email protected]>
sourishkrout pushed a commit to stateful/linkerd-website that referenced this pull request Aug 23, 2023
* Introduce pod-to-pod communication outline for edge docs

Signed-off-by: Matei David <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants