-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce pod-to-pod communication outline for edge docs #1655
Conversation
Signed-off-by: Matei David <[email protected]>
linkerd.io/content/2-edge/features/flat-network-multicluster.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be good to introduce both modes from the beginning, so users don't have to wait till way down the doc to discover about the p2p mode.
Co-authored-by: Alejandro Pedraza <[email protected]>
Signed-off-by: Matei David <[email protected]>
@@ -0,0 +1,91 @@ | |||
+++ | |||
title = "Multi-cluster communication in flat networks" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just looking at this from the outside, it feels like this separate feature doc shouldn't exist, and any additional content should be rolled into the existing multicluster feature doc.
Signed-off-by: William Morgan <[email protected]>
I've updated these docs to my semi-satisfaction, including moving the second doc to the reference section where I think it was intended to be. There is some repetition between feature & reference docs which is not ideal but is palatable. There is a section at the end of the reference doc about namespace sameness that I left in, but I think this is more confusing than helpful and I'm not sure what the actual implications are for users. Keep your control plane namespaces the same? I would like to remove this section but perhaps I'm missing somethign. |
Also: there is still one reference that needs to be fixed once we have the URL. |
Signed-off-by: William Morgan <[email protected]>
5258c09
to
84380d6
Compare
84380d6
to
06fb840
Compare
* Introduce pod-to-pod communication outline for edge docs Signed-off-by: Matei David <[email protected]>
* Introduce pod-to-pod communication outline for edge docs Signed-off-by: Matei David <[email protected]>
Still a work in progress