-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[server][vpj][controller] Add support to ingest from separate RT topic in A/A SIT when feature is enabled #1311
base: main
Are you sure you want to change the base?
Conversation
bb98be2
to
d4ab149
Compare
4308008
to
3d35318
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for preparing this! I am still in the middle of reading the SIT changes, just left a few comments.
...rc/integrationTest/java/com/linkedin/venice/endToEnd/TestSeparateRealtimeTopicIngestion.java
Show resolved
Hide resolved
return pubSubTopicPartition; | ||
} | ||
|
||
PubSubTopicRepository getPubSubTopicRepository() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems this test-only PubSubTopicRepository is not necessary, PubSubTopicImpl could handle equal check by comparing String name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, actually this is used in main code as well. PubSubTopicImpl constructor is package private by design so it is not accessible from SIT class.
[server][vpj][controller] Add support to ingest from separate RT topic in A/A SIT when feature is enabled
This PR continue the work from #1262 and #1172 to add server side ingestion functionality for separate realtime topic.
How was this PR tested?
Added new integration test; Added some unit tests for test coverage; Adjusted some old integration test / unit test behaviors.
Does this PR introduce any user-facing changes?