Skip to content

Commit 4308008

Browse files
committed
avoid emitting metrics for non-sep SIT
1 parent 3187bca commit 4308008

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

clients/da-vinci-client/src/main/java/com/linkedin/davinci/kafka/consumer/StoreIngestionTask.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -4404,6 +4404,10 @@ public boolean hasAllPartitionReportedCompleted() {
44044404
return true;
44054405
}
44064406

4407+
public boolean isSeparatedRealtimeTopicEnabled() {
4408+
return isSeparatedRealtimeTopicEnabled;
4409+
}
4410+
44074411
PubSubTopicPartition resolveTopicPartitionWithKafkaURL(
44084412
PubSubTopic topic,
44094413
PartitionConsumptionState partitionConsumptionState,
@@ -4420,10 +4424,6 @@ PubSubTopicPartition resolveTopicPartitionWithKafkaURL(
44204424
return pubSubTopicPartition;
44214425
}
44224426

4423-
boolean isSeparatedRealtimeTopicEnabled() {
4424-
return isSeparatedRealtimeTopicEnabled;
4425-
}
4426-
44274427
PubSubTopicRepository getPubSubTopicRepository() {
44284428
return pubSubTopicRepository;
44294429
}

clients/da-vinci-client/src/main/java/com/linkedin/davinci/stats/IngestionStatsReporter.java

+6
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@
4343

4444
import com.linkedin.venice.common.VeniceSystemStoreUtils;
4545
import com.linkedin.venice.utils.RegionUtils;
46+
import com.linkedin.venice.utils.Utils;
4647
import io.tehuti.metrics.MetricsRepository;
4748
import io.tehuti.metrics.stats.AsyncGauge;
4849
import it.unimi.dsi.fastutil.ints.Int2ObjectMap;
@@ -344,6 +345,11 @@ protected void registerConditionalStats() {
344345
.getServerConfig()
345346
.getKafkaClusterIdToAliasMap()
346347
.int2ObjectEntrySet()) {
348+
// We will only register sensor for SIT with separate RT topic enabled to avoid unnecessary metrics.
349+
if (getStats().getIngestionTask().isSeparatedRealtimeTopicEnabled()
350+
&& Utils.isSeparateTopicRegion(entry.getValue())) {
351+
continue;
352+
}
347353
int regionId = entry.getIntKey();
348354
String regionNamePrefix = RegionUtils.getRegionSpecificMetricPrefix(
349355
getStats().getIngestionTask().getServerConfig().getRegionName(),

0 commit comments

Comments
 (0)