Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

[Do not merge] PR for diff of DANDI vs. LINC #63

Closed
wants to merge 170 commits into from

Conversation

aaronkanzer
Copy link

Moves dandi#1516 into LINC repo

Cc @kabilar

@@ -477,8 +479,7 @@
digest: Digest | None = None,
ignore_errors: bool = True,
) -> BareAsset:
# Avoid heavy import by importing within function:
from dandi.metadata.nwb import nwb2asset
from lincbrain.metadata.nwb import nwb2asset

Check notice

Code scanning / CodeQL

Cyclic import Note

Import of module
lincbrain.metadata.nwb
begins an import cycle.
@aaronkanzer aaronkanzer changed the title PR for diff of DANDI vs. LINC [Do not merge] PR for diff of DANDI vs. LINC Oct 30, 2024
@aaronkanzer aaronkanzer marked this pull request as draft October 30, 2024 19:55
@kabilar
Copy link
Member

kabilar commented Nov 5, 2024

Thanks @aaronkanzer. I have reviewed all the changes and posted my notes in dandi#1517.

@kabilar
Copy link
Member

kabilar commented Nov 19, 2024

Closing since we are now using the dandi client.

@kabilar kabilar closed this Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants