Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accounting Oracle integration tests #136

Merged
merged 50 commits into from
Sep 5, 2024
Merged

Accounting Oracle integration tests #136

merged 50 commits into from
Sep 5, 2024

Conversation

vp4242
Copy link
Member

@vp4242 vp4242 commented Jul 25, 2024 •
edited
Loading

Accounting Oracle integration tests

@vp4242 vp4242 added the tests Pull requests that add or update tests. label Jul 25, 2024
Base automatically changed from feat/integration to repovation August 2, 2024 11:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024 •
edited
Loading

badge

Hardhat Unit Tests Coverage Summary

Filename                                                       Stmts    Miss  Cover    Missing
-----------------------------------------------------------  -------  ------  -------  ---------
contracts/0.4.24/Lido.sol                                        212       0  100.00%
contracts/0.4.24/StETH.sol                                        72       0  100.00%
contracts/0.4.24/StETHPermit.sol                                  15       0  100.00%
contracts/0.4.24/lib/Packed64x4.sol                                5       0  100.00%
contracts/0.4.24/lib/SigningKeys.sol                              36       0  100.00%
contracts/0.4.24/lib/StakeLimitUtils.sol                          37       0  100.00%
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                   485       0  100.00%
contracts/0.4.24/oracle/LegacyOracle.sol                          72       0  100.00%
contracts/0.4.24/utils/Pausable.sol                                9       0  100.00%
contracts/0.4.24/utils/Versioned.sol                               5       0  100.00%
contracts/0.6.12/WstETH.sol                                       17       0  100.00%
contracts/0.8.4/WithdrawalsManagerProxy.sol                       61       0  100.00%
contracts/0.8.9/BeaconChainDepositor.sol                          21       2  90.48%   48, 51
contracts/0.8.9/Burner.sol                                        71       0  100.00%
contracts/0.8.9/DepositSecurityModule.sol                        104       0  100.00%
contracts/0.8.9/EIP712StETH.sol                                   16       0  100.00%
contracts/0.8.9/LidoExecutionLayerRewardsVault.sol                16       0  100.00%
contracts/0.8.9/LidoLocator.sol                                   18       0  100.00%
contracts/0.8.9/OracleDaemonConfig.sol                            28       0  100.00%
contracts/0.8.9/StakingRouter.sol                                303       0  100.00%
contracts/0.8.9/WithdrawalQueue.sol                               88       0  100.00%
contracts/0.8.9/WithdrawalQueueBase.sol                          146       0  100.00%
contracts/0.8.9/WithdrawalQueueERC721.sol                         89       0  100.00%
contracts/0.8.9/WithdrawalVault.sol                               21       0  100.00%
contracts/0.8.9/lib/Math.sol                                       4       0  100.00%
contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol                22       0  100.00%
contracts/0.8.9/lib/UnstructuredRefStorage.sol                     2       0  100.00%
contracts/0.8.9/oracle/AccountingOracle.sol                      171       1  99.42%   723
contracts/0.8.9/oracle/BaseOracle.sol                             89       1  98.88%   397
contracts/0.8.9/oracle/HashConsensus.sol                         263       1  99.62%   1005
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol                91      91  0.00%    96-461
contracts/0.8.9/proxy/OssifiableProxy.sol                         17       0  100.00%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol      171       0  100.00%
contracts/0.8.9/utils/DummyEmptyContract.sol                       0       0  100.00%
contracts/0.8.9/utils/PausableUntil.sol                           31       0  100.00%
contracts/0.8.9/utils/Versioned.sol                               11       0  100.00%
contracts/0.8.9/utils/access/AccessControl.sol                    23       0  100.00%
contracts/0.8.9/utils/access/AccessControlEnumerable.sol           9       0  100.00%
TOTAL                                                           2851      96  96.63%

Diff against master

Filename                                                       Stmts    Miss  Cover
-----------------------------------------------------------  -------  ------  --------
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol      -54       0  +100.00%
TOTAL                                                            -54       0  -0.03%

Results for commit: ba80c84

Minimum allowed coverage is 95%

♻️ This comment has been updated with latest results

@vp4242
feat: initial accounting integration tests port
4915a6e
@vp4242
test: first accounting test
8f6707c
@vp4242
test: negative rebase report
31da8a4
@vp4242
fix: dependencies
7ea732d
@vp4242
chore: remove duplicate function
1f388f1
@vp4242
test: make tests anvil friendly
4041f22
@vp4242
test: add positive CL rebase close to the limits
2d810c0
@vp4242
test: sanity checker revert report
a7fc514
@vp4242
test: remove block specific requests
b9d1d90
@vp4242
test: remove more block specific requests
e51e178
@vp4242
test: should account correctly if no EL rewards
e6b36eb
@vp4242
test: should account correctly normal EL rewards
69411e7
@vp4242
test: should account correctly EL rewards at limits
d0f3f24
@vp4242
chore: fix rebaseLimitWei() and usage
49ec136
@vp4242
test: should account correctly EL rewards above limits
cae98c6
@vp4242
fix: case for non-finalized withdrawal queue
8c8e857
@vp4242
fix: case for non-finalized withdrawal queue
b03056a
@vp4242
test: should account correctly with no withdrawals
8647165
@vp4242
fix: formatting
be68357
@vp4242
fix: clarify report phases log
c3fa30d
@vp4242
feat: add wstETH contract to discovery
e877cc4
@vp4242
test: add helpers
dc74135
@vp4242
test: add more tests
37e6b03
@vp4242
test: add final tests
203a5e9
tamtamchik
tamtamchik requested changes Aug 26, 2024
View reviewed changes
Copy link
Member

@tamtamchik tamtamchik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! There don't seem to be many questions! 🦄

But, I attempted to run tests on the locally deployed version of the protocol, but they failed. Can you please check? It's possible that they are missing some provisioning.

lib/protocol/discover.ts Outdated Show resolved Hide resolved
lib/protocol/helpers/accounting.ts Outdated Show resolved Hide resolved
test/integration/accounting.ts Outdated Show resolved Hide resolved
test/integration/accounting.ts Outdated Show resolved Hide resolved
test/integration/accounting.ts Outdated Show resolved Hide resolved
test/integration/accounting.ts Outdated Show resolved Hide resolved
@tamtamchik tamtamchik mentioned this pull request Aug 26, 2024
Open
37 tasks
tamtamchik and others added 19 commits August 30, 2024 13:56
@tamtamchik
Merge branch 'feat/integration-deployment' into feat/accounting-scratch
0de12c0
@tamtamchik
Merge branch 'feat/integration-deployment' into feat/accounting-scratch
02d9e83
@vp4242
fix: better logging texts
05a770f
@vp4242
fix: remove dedicated getEvents()
9699355
@vp4242
test: move setting balance inside snapshotted part
5010074
@vp4242
test: add some comments
d54bedc
@vp4242
test: remove logging, add chech
4719d3c
@vp4242
test: add more comments
e6fa3f1
@tamtamchik
Merge branch 'feat/oracle-integration' into feat/accounting-scratch
ad59107
@tamtamchik
Merge branch 'feat/integration-deployment' into feat/accounting-scratch
0d8c410
@tamtamchik
Merge branch 'feat/integration-deployment' into feat/accounting-scratch
af4643b
@tamtamchik
chore: some tooling upgrades
81b018f
@tamtamchik
chore: improve resolution
06f8c55
@tamtamchik
chore: 9 of 10 accounting tests stabilized
f751ee9
@tamtamchik
chore: accounting should work
1c6d9e0
@tamtamchik
Merge branch 'repovation' into feat/accounting-scratch
fa677e0
@tamtamchik
Merge branch 'repovation' into feat/oracle-integration
4cd08ae
@tamtamchik
Merge branch 'feat/oracle-integration' into feat/accounting-scratch
788bbce
@tamtamchik
Merge pull request #199 from lidofinance/feat/accounting-scratch
838938e 
feat: accounting oracle integration tests on scratch deploy
@tamtamchik tamtamchik requested a review from a team as a code owner September 5, 2024 14:55
@tamtamchik tamtamchik removed the request for review from a team September 5, 2024 14:55
tamtamchik
tamtamchik approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@tamtamchik tamtamchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tamtamchik tamtamchik merged commit 7febc70 into repovation Sep 5, 2024
10 checks passed
@tamtamchik tamtamchik deleted the feat/oracle-integration branch September 5, 2024 15:47
@tamtamchik tamtamchik mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamtamchik tamtamchik tamtamchik approved these changes

Assignees
No one assigned
Labels
tests Pull requests that add or update tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vp4242 @tamtamchik