Account for different 'layout's in sampletable #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a helper function that recursively searches the directory structure and returns the path to the top level directory in an lcdb-wf repo
-Implemented changes to account for 'LibraryLayout', 'Layout' and 'layout' formats in sampletable. -Refactored the test suite and added pytest tests to check for correctness
Changed import statement for helpers package that was causing an error
Improve the way the layout column is checked and remove the test parameter and functionality in load_config as it has become clear that implementing unit tests will require its own issues and resolutions
Make sure the table is in fact an SRA sampletable before checking the layout
|
Addresses #407 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Implemented changes to account for 'LibraryLayout', 'Layout' and 'layout' formats in sampletable.
-Refactored the test suite and added pytest tests to check for correctness
-Added a helper function that recursively searches the directory structure and returns the path to the top level directory in an lcdb-wf repo