Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work in progress: CircleCI inline orbs #385

Open
wants to merge 7 commits into
base: v1.10.3rc
Choose a base branch
from

Conversation

aliciaaevans
Copy link
Contributor

Creating a PR to test CircleCI changes

@aliciaaevans aliciaaevans changed the base branch from v1.10.3rc to 378-deploy-script-error July 28, 2023 21:22
@aliciaaevans aliciaaevans changed the base branch from 378-deploy-script-error to v1.10.3rc August 1, 2023 20:52
cd /tmp/

# Deploy to the new directory, so we are testing the real-world case of post-deployment.
# Note that $DEPLOY is set in the "set-paths" step configured above.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Note that $DEPLOY is set in the "set-paths" step configured above.
# Note that $DEPLOY is set in the "set-paths" step configured below.

- run:
name: Download example data
command: |
set -x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tree stuff left over from my debugging on the last PR, I could go either way with keeping it. I guess it doesn't cost anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants