Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ready for Audit] Create MerkleTreeAirdropForERC20 module #16

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Ready for Audit] Create MerkleTreeAirdropForERC20 module #16

wants to merge 3 commits into from

Conversation

deep-quality-dev
Copy link

No description provided.

solcmoon
solcmoon reviewed Feb 2, 2023
View reviewed changes
MerkleTreeAirdrop/README.md Outdated Show resolved Hide resolved
MerkleTreeAirdrop/README.md Outdated Show resolved Hide resolved
@solcmoon
Copy link

solcmoon commented Feb 2, 2023 •
edited
Loading

@deep-quality-dev
Can you override connectToOtherContracts function?
So users can integrate ERC20 module and this module when they deploy smart contracts.

@deep-quality-dev deep-quality-dev changed the title Create MerkleTreeAirdrop Module Create MerkleTreeAirdropForERC20 Module Feb 5, 2023
@solcmoon solcmoon mentioned this pull request Feb 6, 2023
Open
oselezi
oselezi suggested changes Feb 13, 2023
View reviewed changes
MerkleTreeAirdrop/.env.example Outdated
@@ -0,0 +1,7 @@
GOERLI_INFURA_API_KEY=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove file

MerkleTreeAirdrop/.prettierrc Outdated Show resolved Hide resolved
MerkleTreeAirdrop/contracts/MerkleTreeAirdrop.sol Outdated
address public token;

constructor(address token_, bytes32 merkleRoot_) {
token = token_;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low Severity (Information): Zero Address Check

MerkleTreeAirdrop.constructor(address,bytes32).token_ lacks a zero-check on :
                - token = token_

Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#missing-zero-address-validation

Recommendation: if (token_ == address(0)) { /* DO SOMETHING */ }

@oselezi
Copy link
Contributor

oselezi commented Feb 13, 2023

After you fix those three, you can change this PR title to [Ready for Audit] Create MerkleTreeAirdropForERC20 module.

oselezi
oselezi suggested changes Feb 14, 2023
View reviewed changes
MerkleTreeAirdrop/hardhat.config.ts Outdated Show resolved Hide resolved
MerkleTreeAirdrop/package.json Outdated Show resolved Hide resolved
MerkleTreeAirdrop/scripts/deploy.ts Outdated
@@ -0,0 +1,46 @@
import { ethers, run } from "hardhat";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove entire scripts folder

MerkleTreeAirdrop/tsconfig.json Outdated Show resolved Hide resolved
@deep-quality-dev deep-quality-dev changed the title Create MerkleTreeAirdropForERC20 Module [Ready for Audit] Create MerkleTreeAirdropForERC20 module Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solcmoon solcmoon solcmoon left review comments

@oselezi oselezi oselezi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deep-quality-dev @solcmoon @oselezi