Create StakingERC721 Module #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solcmoon
reviewed
Feb 6, 2023
oselezi
suggested changes
Feb 13, 2023
| @@ -0,0 +1,377 @@ | |||
| // SPDX-License-Identifier: UNLICENSED | |||
| pragma solidity ^0.8.0; | |||
There was a problem hiding this comment.
Your module minimum version is 0.8.9, compile errors occur when you use ^0.8.0 here, but if you use hardhat compiler 0.8.0. please update version to ^0.8.9.
There was a problem hiding this comment.
We can follow the order of functions as following:
https://docs.soliditylang.org/en/v0.8.17/style-guide.html#order-of-functions
|
|
||
| uint256 amount; | ||
| uint256 length = tokenIds.length; | ||
| for (uint256 i = 0; i < length; ++i) { |
There was a problem hiding this comment.
Calls inside a loop
Severity: Low
Confidence: Medium
Description
Calls inside a loop might lead to a denial-of-service attack.
If one of the destinations has a fallback function that reverts, bad will always revert.
Recommendation
Favor pull over push strategy for external calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.