Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect condition in CliLogger::message() method #299

Closed
wants to merge 1 commit into from

Conversation

MahdiBagheri71
Copy link

Expected behavior:
The channel_data should be decoded correctly.

Proposed fix:
Replace the condition in the if statement with the correct one:

if (isset($message['data']['channel_data']) && is_string($message['data']['channel_data'])) {
    $message['data']['channel_data'] = json_decode($message['data']['channel_data'], true);
}

@crynobone crynobone linked an issue Jan 9, 2025 that may be closed by this pull request
@crynobone crynobone changed the title fix: Fix incorrect condition in CliLogger::message method Fix incorrect condition in CliLogger::message method Jan 9, 2025
@crynobone crynobone changed the title Fix incorrect condition in CliLogger::message method Fix incorrect condition in CliLogger::message() method Jan 9, 2025
@taylorotwell
Copy link
Member

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.

Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect condition in CliLogger::message method
2 participants