Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect condition in CliLogger::message method #298

Open
MahdiBagheri71 opened this issue Jan 9, 2025 · 1 comment
Open

Incorrect condition in CliLogger::message method #298

MahdiBagheri71 opened this issue Jan 9, 2025 · 1 comment

Comments

@MahdiBagheri71
Copy link

Reverb Version

1.4

Laravel Version

11.36

PHP Version

8.3

Description

There is an incorrect condition in the CliLogger::message method in the vendor/laravel/reverb/src/Loggers/CliLogger.php file. The condition should check if message['data']['channel_data'] is a string, not message['data'].

Steps To Reproduce

  1. Log a message with channel_data as a string.
  2. Observe that the channel_data is not decoded correctly.
@crynobone crynobone linked a pull request Jan 9, 2025 that will close this issue
Fix incorrect condition in CliLogger::message() method #299
Closed
@joedixon
Copy link
Collaborator

Can you share a screenshot of the issue you are seeing on the CLI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect condition in CliLogger::message() method MahdiBagheri71/reverb
2 participants
@joedixon @MahdiBagheri71