Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove static lifetime for name str parameter requirement for constant getter #1523

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Merge branch 'main' into fix/get_constant_from_var_name

15ba235
Select commit
Loading
Failed to load commit list.
Open

fix: remove static lifetime for name str parameter requirement for constant getter #1523

Merge branch 'main' into fix/get_constant_from_var_name
15ba235
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 24, 2024 in 1s

97.13% (+0.00%) compared to 0a39534

View this Pull Request on Codecov

97.13% (+0.00%) compared to 0a39534

Details

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (0a39534) 97.12% compared to head (15ba235) 97.13%.

❗ Current head 15ba235 differs from pull request most recent head 6b22b68. Consider uploading reports for the commit 6b22b68 to get more accurate results

Files Patch % Lines
...uiltin_hint_processor/cairo_keccak/keccak_hints.rs 71.42% 4 Missing ⚠️
...int_processor/builtin_hint_processor/math_utils.rs 77.77% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1523   +/-   ##
=======================================
  Coverage   97.12%   97.13%           
=======================================
  Files          91       91           
  Lines       37246    37187   -59     
=======================================
- Hits        36176    36120   -56     
+ Misses       1070     1067    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.