Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove static lifetime for name str parameter requirement for constant getter #1523

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Merge branch 'main' into fix/get_constant_from_var_name

15ba235
Select commit
Loading
Failed to load commit list.
Open

fix: remove static lifetime for name str parameter requirement for constant getter #1523

Merge branch 'main' into fix/get_constant_from_var_name
15ba235
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jan 24, 2024 in 0s

79.31% of diff hit (target 97.12%)

View this Pull Request on Codecov

79.31% of diff hit (target 97.12%)

Annotations

Check warning on line 121 in vm/src/hint_processor/builtin_hint_processor/cairo_keccak/keccak_hints.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

vm/src/hint_processor/builtin_hint_processor/cairo_keccak/keccak_hints.rs#L121 

Added line #L121 was not covered by tests

Check warning on line 155 in vm/src/hint_processor/builtin_hint_processor/cairo_keccak/keccak_hints.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

vm/src/hint_processor/builtin_hint_processor/cairo_keccak/keccak_hints.rs#L155 

Added line #L155 was not covered by tests

Check warning on line 222 in vm/src/hint_processor/builtin_hint_processor/cairo_keccak/keccak_hints.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

vm/src/hint_processor/builtin_hint_processor/cairo_keccak/keccak_hints.rs#L222 

Added line #L222 was not covered by tests

Check warning on line 259 in vm/src/hint_processor/builtin_hint_processor/cairo_keccak/keccak_hints.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

vm/src/hint_processor/builtin_hint_processor/cairo_keccak/keccak_hints.rs#L259 

Added line #L259 was not covered by tests

Check warning on line 110 in vm/src/hint_processor/builtin_hint_processor/math_utils.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

vm/src/hint_processor/builtin_hint_processor/math_utils.rs#L110 

Added line #L110 was not covered by tests

Check warning on line 113 in vm/src/hint_processor/builtin_hint_processor/math_utils.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

vm/src/hint_processor/builtin_hint_processor/math_utils.rs#L113 

Added line #L113 was not covered by tests
View more details on Codecov