Add V1VirtualMachine object to OpenshiftVM #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaacov
approved these changes
Sep 14, 2023
rszwajko
force-pushed
the
v1VirtualMachine
branch
from
0012742 to
71604e6
Compare
rszwajko
force-pushed
the
v1VirtualMachine
branch
from
71604e6 to
85867ae
Compare
yaacov
reviewed
Sep 18, 2023
...c/modules/Providers/views/details/tabs/VirtualMachines/components/VMConcernsCellRenderer.tsx
Outdated
Show resolved
Hide resolved
yaacov
reviewed
Sep 18, 2023
...ules/Providers/views/details/tabs/VirtualMachines/utils/helpers/getHighestPriorityConcern.ts
Outdated
Show resolved
Hide resolved
rszwajko
force-pushed
the
v1VirtualMachine
branch
from
85867ae to
31400f4
Compare
rszwajko
changed the title
Add partial type definitions for KubeVirt VirtualMachine. Signed-off-by: Radoslaw Szwajkowski <[email protected]>
rszwajko
force-pushed
the
v1VirtualMachine
branch
from
31400f4 to
b85380f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yaacov
It seems that current definition is different then used by the backend.
See:
https://github.com/kubev2v/forklift/blob/ea39abb9a03e788fd63af010e8d48944d38a1fbf/pkg/controller/provider/web/ocp/vm.go#L131
EDIT: changes in the UI and the components will be handled in a separate PR after other type changes are implemeted