Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render VMs power state as icon with tooltip #723

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Render VMs power state as icon with tooltip #723

merged 3 commits into from
Sep 27, 2023

Conversation

rszwajko
Copy link
Contributor

@rszwajko rszwajko commented Sep 8, 2023

Screenshot from 2023-09-08 19-02-34
Screenshot from 2023-09-08 19-02-24

@rszwajko rszwajko requested review from yaacov, sjd78 and sgratch September 8, 2023 17:11
@yaacov
Copy link
Member

yaacov commented Sep 11, 2023

Ref: #719

@rszwajko rszwajko force-pushed the vmPowerState branch 4 times, most recently from e86adf5 to 9eb8c88 Compare September 15, 2023 17:32
@rszwajko
Copy link
Contributor Author

Newest force push add dependency on #728

  1. added displaying power state for all providers except OVA
  2. fixed filtering by status

image

@rszwajko rszwajko marked this pull request as ready for review September 15, 2023 17:34
@yaacov yaacov mentioned this pull request Sep 18, 2023
Merged
@rszwajko rszwajko marked this pull request as draft September 18, 2023 20:30
@rszwajko rszwajko force-pushed the vmPowerState branch 4 times, most recently from 9255bc3 to 3d6cef9 Compare September 25, 2023 14:50
@rszwajko rszwajko marked this pull request as ready for review September 25, 2023 20:13
@yaacov
Copy link
Member

yaacov commented Sep 27, 2023

@rszwajko hi, can you update the screenshots and cleanup the commits ?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
9.5% 9.5% Duplication

@rszwajko
Copy link
Contributor Author

Newest force push:

  1. removed unnecessary casts (as pointed above)
  2. added missing status column for OpenShift - got lost at some point

@yaacov yaacov merged commit 60b0969 into kubev2v:main Sep 27, 2023
5 checks passed
@rszwajko rszwajko mentioned this pull request Oct 25, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaacov yaacov yaacov left review comments

@sjd78 sjd78 Awaiting requested review from sjd78

@sgratch sgratch Awaiting requested review from sgratch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rszwajko @yaacov