Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrase the preserve static IPs warning message #1405

Merged
merged 1 commit into from
Dec 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@
"Cannot retrieve certificate": "Cannot retrieve certificate",
"Category": "Category",
"Certificate change detected": "Certificate change detected",
"choose a different mapping for your migration plan": "choose a different mapping for your migration plan",
"Choose the root filesystem to be converted.": "Choose the root filesystem to be converted.",
"Clear all filters": "Clear all filters",
"Click the pencil for setting provider web UI link": "Click the pencil for setting provider web UI link",
Expand Down Expand Up @@ -200,7 +201,6 @@
"First root device": "First root device",
"Flavor": "Flavor",
"Folder": "Folder",
"For fixing, update the destination network mappings to avoid using the 'Pod Networking' type.": "For fixing, update the destination network mappings to avoid using the 'Pod Networking' type.",
"GPUs/Host Devices": "GPUs/Host Devices",
"Hide from view": "Hide from view",
"Hide values": "Hide values",
Expand Down Expand Up @@ -378,7 +378,6 @@
"Preserve static IPs": "Preserve static IPs",
"Preserve the CPU model and flags the VM runs with in its oVirt cluster.": "Preserve the CPU model and flags the VM runs with in its oVirt cluster.",
"Preserve the static IPs of virtual machines migrated from vSphere.": "Preserve the static IPs of virtual machines migrated from vSphere.",
"Preserving static IPs of VMs might fail": "Preserving static IPs of VMs might fail",
"Product": "Product",
"Progress": "Progress",
"Project": "Project",
Expand Down Expand Up @@ -495,7 +494,6 @@
"The Manager CA certificate unless it was replaced by a third-party certificate, in which case, enter the Manager Apache CA certificate.": "The Manager CA certificate unless it was replaced by a third-party certificate, in which case, enter the Manager Apache CA certificate.",
"The password for the ESXi host admin": "The password for the ESXi host admin",
"The plan is not ready": "The plan is not ready",
"The plan is set to preserve the static IPs of VMs mapped to a Pod network type. This is not supported and therefore VM IPs can be changed during the migration process.": "The plan is set to preserve the static IPs of VMs mapped to a Pod network type. This is not supported and therefore VM IPs can be changed during the migration process.",
"The plan migration might not work as expected": "The plan migration might not work as expected",
"The provider is not ready": "The provider is not ready",
"The provider is not ready.": "The provider is not ready.",
Expand Down Expand Up @@ -579,5 +577,6 @@
"You can select a migration network for a source provider to reduce risk to the source environment and to improve performance.": "You can select a migration network for a source provider to reduce risk to the source environment and to improve performance.",
"You can select a migration network. If you do not select a migration network,\n the default migration network is set to the providers default transfer network.": "You can select a migration network. If you do not select a migration network,\n the default migration network is set to the providers default transfer network.",
"You can select a migration target namespace for the migration virtual machines.": "You can select a migration target namespace for the migration virtual machines.",
"You don't have access to this section due to cluster policy.": "You don't have access to this section due to cluster policy."
"You don't have access to this section due to cluster policy.": "You don't have access to this section due to cluster policy.",
"Your migration plan preserves the static IPs of VMs and uses Pod Networking target network mapping. This combination isn't supported, because VM IPs aren't preserved in Pod Networking migrations.": "Your migration plan preserves the static IPs of VMs and uses Pod Networking target network mapping. This combination isn't supported, because VM IPs aren't preserved in Pod Networking migrations."
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { canPlanReStart, canPlanStart, getPlanPhase } from 'src/modules/Plans/ut
import { useGetDeleteAndEditAccessReview } from 'src/modules/Providers/hooks';
import { useModal } from 'src/modules/Providers/modals';
import { PageHeadings } from 'src/modules/Providers/utils';
import { useForkliftTranslation } from 'src/utils';
import { ForkliftTrans, useForkliftTranslation } from 'src/utils';

import {
NetworkMapModelGroupVersionKind,
Expand Down Expand Up @@ -97,13 +97,18 @@ export const PlanPageHeadings: React.FC<{ name: string; namespace: string }> = (
if (preserveIpsWithPodMapCondition()) {
alerts.push(
<PlanWarningCondition
type={t('Preserving static IPs of VMs might fail')}
type={t('choose a different mapping for your migration plan')}
message={t(
'The plan is set to preserve the static IPs of VMs mapped to a Pod network type. This is not supported and therefore VM IPs can be changed during the migration process.',
)}
suggestion={t(
"For fixing, update the destination network mappings to avoid using the 'Pod Networking' type.",
"Your migration plan preserves the static IPs of VMs and uses Pod Networking target network mapping. This combination isn't supported, because VM IPs aren't preserved in Pod Networking migrations.",
)}
suggestion={
<ForkliftTrans>
If your VMs use static IPs, click the Mappings tab of your plan, and choose a
different target network mapping.
<br />
If your VMs don&apos;t use static IPs, you can ignore this message.
</ForkliftTrans>
}
/>,
);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import React, { ReactNode } from 'react';
import { useTranslation } from 'react-i18next';
import Linkify from 'react-linkify';
import { EMPTY_MSG } from 'src/utils/constants';
Expand All @@ -8,7 +8,7 @@ import { Alert, AlertVariant, Text, TextContent, TextVariants } from '@patternfl
const PlanWarningCondition: React.FC<{
type: string;
message: string;
suggestion: string;
suggestion: ReactNode;
}> = ({ type, message, suggestion }) => {
const { t } = useTranslation();
return (
Expand Down
Loading