Rephrase the preserve static IPs warning message #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1405 +/- ##
==========================================
- Coverage 36.81% 36.21% -0.60%
==========================================
Files 158 159 +1
Lines 2548 2579 +31
Branches 599 603 +4
==========================================
- Hits 938 934 -4
- Misses 1428 1463 +35
Partials 182 182 ☔ View full report in Codecov by Sentry. |
sgratch
added
bug
|
cc:// @RichardHoch |
sgratch
force-pushed
the
rephrase-preserve-static-IP-warning
branch
from
eee3bc2 to
88d6ba1
Compare
Reference: https://issues.redhat.com/browse/MTV-1503 Based on Doc's review, rephrase the warning message for preserving static IPs while using Pod networking. Change the PlanWarningCondition component to enable flexible formatting of the suggested section. Signed-off-by: Sharon Gratch <[email protected]>
sgratch
force-pushed
the
rephrase-preserve-static-IP-warning
branch
from
88d6ba1 to
ed60f78
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://issues.redhat.com/browse/MTV-1503
Based on Doc's review, rephrase the warning message for preserving static IPs while using Pod networking.
Change the
PlanWarningConditioncomponent to enable flexible formatting of the suggested section.Screenshot