Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add non-documented translation requirements #20727

Merged
merged 1 commit into from
May 5, 2020
Merged

Add non-documented translation requirements #20727

merged 1 commit into from
May 5, 2020

Conversation

MaxymVlasov
Copy link
Member

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 2, 2020
@k8s-ci-robot k8s-ci-robot added language/uk Issues or PRs related to Ukrainian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 2, 2020
@netlify
Copy link

netlify bot commented May 2, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4a6d83c

https://deploy-preview-20727--kubernetes-io-master-staging.netlify.app

@Arhell
Copy link
Member

Arhell commented May 3, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

@Arhell: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

idvoretskyi
idvoretskyi approved these changes May 3, 2020
View reviewed changes
Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2020
@MaxymVlasov
Copy link
Member Author

/approve
Just check are bot checking that approver is PR creator or not :)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaxymVlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2909bc8 into kubernetes:master May 5, 2020
@MaxymVlasov
Copy link
Member Author

Lol. This looks like a bug. I will create issue on it.

@MaxymVlasov MaxymVlasov deleted the patch-1 branch May 5, 2020 16:28
@MaxymVlasov MaxymVlasov mentioned this pull request May 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idvoretskyi idvoretskyi idvoretskyi approved these changes

@Potapy4 Potapy4 Awaiting requested review from Potapy4

Assignees

@idvoretskyi idvoretskyi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/uk Issues or PRs related to Ukrainian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaxymVlasov @Arhell @k8s-ci-robot @idvoretskyi