Code owner should not can approve it own PRs

[MaxymVlasov]

What happened:
I am owner and I can approve my own PR.

What you expected to happen:
PR creator should not have ability to /approve the PR, regardless is it owner or not.

How to reproduce it (as minimally and precisely as possible):

1. User is code owner/reviewer in repo.
2. Create PR.
3. Send /approve.

Please provide links to example occurrences, if any:
kubernetes/website#20727

Anything else we need to know?:
It can be feature, not bug, but I not think so.

[alvaroaleman]

This can be disabled via a setting on the approve plugin:

test-infra/prow/plugins/config.go

Line 258 in 6e7f925

RequireSelfApproval *bool `json:"require_self_approval,omitempty"`

[MaxymVlasov]

@alvaroaleman If I understood correctly, RequireSelfApproval setting disable by default, and if be set to true - PR creator must be approve it own PR, otherwise PR not be merged. It more looks like WIP bot / Draft PR Github functionality.

But I ask about another stuff:
Folks can fully skip review process on it own PRs if it is owners/reviewers.

[alvaroaleman]

@alvaroaleman If I understood correctly, RequireSelfApproval setting disable by default, and if be set to true - PR creator must be approve it own PR, otherwise PR not be merged. It more looks like WIP bot / Draft PR Github functionality.

No. By default code owners just autoapprove their own change. The semantic meaning of approve is "I approve of the idea of this change", so if you are a codeowners, you automatically approve of the idea of the change of the code you own.

Folks can fully skip review process on it own PRs if it is owners/reviewers.

No. A /lgtm is still required, you can never lgtm your own change

[MaxymVlasov]

Yep, I forgot about /lgtm, if I found that I can /lgtm my own PR, I will repopen this Issue.
Thank you!