Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cilium to ingress2gateway #199

Merged
merged 7 commits into from
Nov 28, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ API.
## Supported providers

* [apisix](pkg/i2gw/providers/apisix/README.md)
* [cilium](pkg./i2gw/providers/cilium/README.md)
* [ingress-nginx](pkg/i2gw/providers/ingressnginx/README.md)
* [istio](pkg/i2gw/providers/istio/README.md)
* [gce](pkg/i2gw/providers/gce/README.md)
Expand Down
1 change: 1 addition & 0 deletions cmd/print.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ import (
_ "github.com/kubernetes-sigs/ingress2gateway/pkg/i2gw/providers/istio"
_ "github.com/kubernetes-sigs/ingress2gateway/pkg/i2gw/providers/kong"
_ "github.com/kubernetes-sigs/ingress2gateway/pkg/i2gw/providers/openapi3"
_ "github.com/kubernetes-sigs/ingress2gateway/pkg/i2gw/providers/cilium"

// Call init for notifications
_ "github.com/kubernetes-sigs/ingress2gateway/pkg/i2gw/notifications"
Expand Down
3 changes: 3 additions & 0 deletions pkg/i2gw/intermediate/intermediate_representation.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ type GatewayContext struct {

type ProviderSpecificGatewayIR struct {
Apisix *ApisixGatewayIR
Cilium *CiliumGatewayIR
Gce *GceGatewayIR
IngressNginx *IngressNginxGatewayIR
Istio *IstioGatewayIR
Expand All @@ -71,6 +72,7 @@ type HTTPRouteContext struct {

type ProviderSpecificHTTPRouteIR struct {
Apisix *ApisixHTTPRouteIR
Cilium *CiliumHTTPRouteIR
Gce *GceHTTPRouteIR
IngressNginx *IngressNginxHTTPRouteIR
Istio *IstioHTTPRouteIR
Expand All @@ -82,6 +84,7 @@ type ProviderSpecificHTTPRouteIR struct {
// extension features on Service.
type ProviderSpecificServiceIR struct {
Apisix *ApisixServiceIR
Cilium *CiliumServiceIR
Gce *GceServiceIR
IngressNginx *IngressNginxServiceIR
Istio *IstioServiceIR
Expand Down
21 changes: 21 additions & 0 deletions pkg/i2gw/intermediate/provider_cilium.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
/*
Copyright 2024 The Kubernetes Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package intermediate

type CiliumGatewayIR struct{}
type CiliumHTTPRouteIR struct{}
type CiliumServiceIR struct{}
8 changes: 8 additions & 0 deletions pkg/i2gw/providers/cilium/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Cilium Provider

The project supports translating [Cilium](https://github.com/cilium/cilium) specific annotations.

## Supported Annotations

- `ingress.cilium.io/force-https:`: This annotation redirects HTTP requests to HTTPS with a `301` status code.

27 changes: 27 additions & 0 deletions pkg/i2gw/providers/cilium/annotations.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
/*
Copyright 2024 The Kubernetes Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package cilium

import "fmt"

const (
annotationPrefix = "ingress.cilium.io"
)

func ciliumAnnotation(suffix string) string {
return fmt.Sprintf("%s/%s", annotationPrefix, suffix)
}
81 changes: 81 additions & 0 deletions pkg/i2gw/providers/cilium/cilium.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
/*
Copyright 2023 The Kubernetes Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package cilium

import (
"context"
"fmt"

"github.com/kubernetes-sigs/ingress2gateway/pkg/i2gw"
"github.com/kubernetes-sigs/ingress2gateway/pkg/i2gw/intermediate"
"github.com/kubernetes-sigs/ingress2gateway/pkg/i2gw/providers/common"
"k8s.io/apimachinery/pkg/util/validation/field"
)

// The Name of the provider.
const Name = "cilium"
const CiliumIngressClass = "cilium"

func init() {
i2gw.ProviderConstructorByName[Name] = NewProvider
}

// Provider implements the i2gw.Provider interface.
type Provider struct {
storage *storage
resourceReader *resourceReader
resourcesToIRConverter *resourcesToIRConverter
}

// NewProvider constructs and returns the apisix implementation of i2gw.Provider.
xtineskim marked this conversation as resolved.
Show resolved Hide resolved
func NewProvider(conf *i2gw.ProviderConf) i2gw.Provider {
return &Provider{
storage: newResourcesStorage(),
resourceReader: newResourceReader(conf),
resourcesToIRConverter: newResourcesToIRConverter(),
}
}

// ToIR converts stored Cilium API entities to intermediate.IR
// including the cilium specific features.
func (p *Provider) ToIR() (intermediate.IR, field.ErrorList) {
return p.resourcesToIRConverter.convertToIR(p.storage)
}

func (p *Provider) ToGatewayResources(ir intermediate.IR) (i2gw.GatewayResources, field.ErrorList) {
return common.ToGatewayResources(ir)
}

func (p *Provider) ReadResourcesFromCluster(ctx context.Context) error {
storage, err := p.resourceReader.readResourcesFromCluster(ctx)
if err != nil {
return fmt.Errorf("failed to read resources from cluster: %w", err)
}

p.storage = storage
return nil
}

func (p *Provider) ReadResourcesFromFile(_ context.Context, filename string) error {
storage, err := p.resourceReader.readResourcesFromFile(filename)
if err != nil {
return fmt.Errorf("failed to read resources from file: %w", err)
}

p.storage = storage
return nil
}
65 changes: 65 additions & 0 deletions pkg/i2gw/providers/cilium/converter.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
/*
Copyright 2023 The Kubernetes Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package cilium

import (
"github.com/kubernetes-sigs/ingress2gateway/pkg/i2gw"
"github.com/kubernetes-sigs/ingress2gateway/pkg/i2gw/intermediate"
"github.com/kubernetes-sigs/ingress2gateway/pkg/i2gw/providers/common"
networkingv1 "k8s.io/api/networking/v1"
"k8s.io/apimachinery/pkg/util/validation/field"
)

// resourcesToIRConverter implements the ToIR function of i2gw.ResourcesToIRConverter interface.
type resourcesToIRConverter struct {
featureParsers []i2gw.FeatureParser
implementationSpecificOptions i2gw.ProviderImplementationSpecificOptions
}

// newResourcesToIRConverter returns a cilium resourcesToIRConverter instance.
func newResourcesToIRConverter() *resourcesToIRConverter {
return &resourcesToIRConverter{
featureParsers: []i2gw.FeatureParser{
forceHTTPSFeature,
},
implementationSpecificOptions: i2gw.ProviderImplementationSpecificOptions{
// The list of the implementationSpecific ingress fields options comes here.
},
}
}

func (c *resourcesToIRConverter) convertToIR(storage *storage) (intermediate.IR, field.ErrorList) {
ingressList := []networkingv1.Ingress{}
for _, ing := range storage.Ingresses {
ingressList = append(ingressList, *ing)
}
// Convert plain ingress resources to gateway resources, ignoring all
// provider-specific features.
ir, errs := common.ToIR(ingressList, c.implementationSpecificOptions)
if len(errs) > 0 {
return intermediate.IR{}, errs
}

for _, parseFeatureFunc := range c.featureParsers {
// Apply the feature parsing function to the gateway resources, one by one.
parseErrs := parseFeatureFunc(ingressList, &ir)
// Append the parsing errors to the error list.
errs = append(errs, parseErrs...)
}

return ir, errs
}
70 changes: 70 additions & 0 deletions pkg/i2gw/providers/cilium/force_https.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
/*
Copyright 2024 The Kubernetes Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package cilium

import (
"fmt"

"github.com/kubernetes-sigs/ingress2gateway/pkg/i2gw/intermediate"
"github.com/kubernetes-sigs/ingress2gateway/pkg/i2gw/notifications"
"github.com/kubernetes-sigs/ingress2gateway/pkg/i2gw/providers/common"
networkingv1 "k8s.io/api/networking/v1"
"k8s.io/apimachinery/pkg/types"
"k8s.io/apimachinery/pkg/util/validation/field"
"k8s.io/utils/ptr"
gatewayv1 "sigs.k8s.io/gateway-api/apis/v1"
)

func forceHTTPSFeature(ingresses []networkingv1.Ingress, ir *intermediate.IR) field.ErrorList {
var errs field.ErrorList
forceHTTPSAnnotation := ciliumAnnotation("force-https")
ruleGroups := common.GetRuleGroups(ingresses)
for _, rg := range ruleGroups {

for _, rule := range rg.Rules {
if val, annotationFound := rule.Ingress.Annotations[forceHTTPSAnnotation]; val == "enabled" || val == "true" {
if rule.Ingress.Spec.Rules == nil {
continue
}
key := types.NamespacedName{Namespace: rule.Ingress.Namespace, Name: common.RouteName(rg.Name, rg.Host)}

httpRoute, ok := ir.HTTPRoutes[key]
if !ok {
errs = append(errs, field.NotFound(field.NewPath("HTTPRoute"), key))
}

for i, rule := range httpRoute.Spec.Rules {
rule.Filters = append(rule.Filters, gatewayv1.HTTPRouteFilter{
Type: gatewayv1.HTTPRouteFilterRequestRedirect,
RequestRedirect: &gatewayv1.HTTPRequestRedirectFilter{
Scheme: ptr.To("https"),
StatusCode: ptr.To(int(301)),
},
})
rule.BackendRefs = nil

httpRoute.Spec.Rules[i] = rule

}
if annotationFound && ok {
notify(notifications.InfoNotification, fmt.Sprintf("parsed \"%v\" annotation of ingress and patched %v fields", forceHTTPSAnnotation, field.NewPath("httproute", "spec", "rules").Key("").Child("filters")), &httpRoute)
}
}
}
}
return errs
}
Loading
Loading