Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cilium to ingress2gateway #199

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add Cilium to ingress2gateway #199

wants to merge 7 commits into from

Conversation

xtineskim
Copy link

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR adds the Cilium project as a provider to the ingress2gateway project, currently capture the force-https annotation

Which issue(s) this PR fixes:

Fixes # n/a

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xtineskim
Once this PR has been reviewed and has the lgtm label, please assign robscott for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 9, 2024
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 9, 2024
@xtineskim xtineskim changed the title I2gw cilium Add Cilium to ingress2gateway Oct 9, 2024
@LiorLieberman
Copy link
Member

/retest

LiorLieberman
LiorLieberman reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@LiorLieberman LiorLieberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xtineskim !
Looks good to me, can you go fmt it? I think thats why it fails

pkg/i2gw/providers/cilium/cilium.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/cilium/resource_reader.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levikobi levikobi Awaiting requested review from levikobi

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

@LiorLieberman LiorLieberman Awaiting requested review from LiorLieberman

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xtineskim @k8s-ci-robot @LiorLieberman