removeChildAt in O(n) instead of O(n^2) and simplify removeChild #2319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the child removal functionality in the Container by changing the removeChildAt method to work in O(n) time instead of O(n²). It includes updated tests that assert the correct count of removed children and validate proper reindexing of remaining children.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| korge/test/korlibs/korge/view/ContainerTest.kt | Added tests to verify removal count and child reindexing behavior |
| korge/src/korlibs/korge/view/Container.kt | Optimized removeChildAt method to remove multiple children in one pass (O(n)) |
soywiz
reviewed
May 2, 2025
soywiz
reviewed
May 2, 2025
soywiz
reviewed
May 3, 2025
soywiz
changed the title
Contributor
|
Thanks @reosfire for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code working in O(n * c) where
nis children count andcis count we are going to remove.This is the optimization to O(n)
Also I don't understand how is it possible that child view from __children list has other container as a parent. Is it expected behavior? If not then maybe the code should throw instead of returning everywhere?