-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Use exact match for filtering by application name #1966
Conversation
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1966 +/- ##
==========================================
+ Coverage 39.20% 42.22% +3.01%
==========================================
Files 146 170 +24
Lines 4857 5450 +593
Branches 1164 1325 +161
==========================================
+ Hits 1904 2301 +397
- Misses 2939 3133 +194
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is weird is that the filter input box doesn't allow general text input. It only allows selection of existing names. So in that context, an exact match looks better than the getItemValue
filter of "name contains the filter text".
In future it may be nice to support a glob input so you can do "Foo*" and pickups all the applications that start with "Foo" without having to select each one.
Exact match ensures that active item is on page.
Example usage: /applications?activeItem=6&filters={"name":["bookserver-app"]}
Resolves: #1974