Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Use exact match for filtering by application name #1966

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

rszwajko
Copy link
Collaborator

@rszwajko rszwajko commented Jun 18, 2024

Exact match ensures that active item is on page.

Example usage: /applications?activeItem=6&filters={"name":["bookserver-app"]}

Resolves: #1974

@rszwajko
Copy link
Collaborator Author

Before - contains-type matching

Screenshot from 2024-06-18 14-54-21

After - exact match

Screenshot from 2024-06-18 14-54-07

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.22%. Comparing base (b654645) to head (1c15dd1).
Report is 177 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1966      +/-   ##
==========================================
+ Coverage   39.20%   42.22%   +3.01%     
==========================================
  Files         146      170      +24     
  Lines        4857     5450     +593     
  Branches     1164     1325     +161     
==========================================
+ Hits         1904     2301     +397     
- Misses       2939     3133     +194     
- Partials       14       16       +2     
Flag Coverage Δ
client 42.22% <ø> (+3.01%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rszwajko rszwajko changed the title ✨ Use exact match for filtering by application name 🐛 Use exact match for filtering by application name Jun 21, 2024
@rszwajko rszwajko marked this pull request as ready for review June 21, 2024 14:55
@rszwajko rszwajko requested a review from sjd78 as a code owner June 21, 2024 14:55
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is weird is that the filter input box doesn't allow general text input. It only allows selection of existing names. So in that context, an exact match looks better than the getItemValue filter of "name contains the filter text".

In future it may be nice to support a glob input so you can do "Foo*" and pickups all the applications that start with "Foo" without having to select each one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Aplication name filter returns too many results
3 participants