Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Use hidden filter category for filtering on page load #1965

Closed
wants to merge 1 commit into from

Conversation

rszwajko
Copy link
Collaborator

Add hidden "id" filter category to application screen to ensure that active item is on page

Example usage: /applications?activeItem=6&filters={"id":["6"]}

Add hidden "id" filter category to application screen to ensure that
active item is on page

Example usage: <server>/applications?activeItem=6&filters={"id":["6"]}

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
@rszwajko
Copy link
Collaborator Author

Active item used together with ID filtering

Screenshot from 2024-06-18 17-03-28

ID filter category not listed in the toolbar

image

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 42.08%. Comparing base (b654645) to head (7550081).
Report is 164 commits behind head on main.

Files Patch % Lines
...src/app/components/FilterToolbar/FilterToolbar.tsx 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1965      +/-   ##
==========================================
+ Coverage   39.20%   42.08%   +2.88%     
==========================================
  Files         146      166      +20     
  Lines        4857     5334     +477     
  Branches     1164     1335     +171     
==========================================
+ Hits         1904     2245     +341     
- Misses       2939     3073     +134     
- Partials       14       16       +2     
Flag Coverage Δ
client 42.08% <0.00%> (+2.88%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rszwajko rszwajko closed this Jun 26, 2024
@rszwajko
Copy link
Collaborator Author

Closing in favor of #1966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant