✨ Implement the Task Manager drawer #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1955 +/- ##
==========================================
+ Coverage 39.20% 42.33% +3.13%
==========================================
Files 146 169 +23
Lines 4857 5405 +548
Branches 1164 1365 +201
==========================================
+ Hits 1904 2288 +384
- Misses 2939 3000 +61
- Partials 14 117 +103
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sjd78
added a commit
to sjd78/tackle2-ui
that referenced
this pull request
Jun 14, 2024
Update the `Task` interface, and related, to follow the current definitions of Task REST resource[1] on the hub. Supports: konveyor#1955, konveyor#1956, konveyor#1957 [1] - https://github.com/konveyor/tackle2-hub/blob/1366d95b62ac7717826fd9f64c9e268013107008/api/task.go#L725-L748 Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
added a commit
to sjd78/tackle2-ui
that referenced
this pull request
Jun 14, 2024
Update the `Task` interface, and related, to follow the current definitions of Task REST resource[1] on the hub. Supports: konveyor#1955, konveyor#1956, konveyor#1957 [1] - https://github.com/konveyor/tackle2-hub/blob/1366d95b62ac7717826fd9f64c9e268013107008/api/task.go#L725-L748 Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
added a commit
that referenced
this pull request
Jun 14, 2024
Update the `Task` interface, and related, to follow the current definitions of Task REST resource[^1] on the hub. Supports: #1955, #1956, #1957 [^1]: https://github.com/konveyor/tackle2-hub/blob/1366d95b62ac7717826fd9f64c9e268013107008/api/task.go#L725-L748 --------- Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
force-pushed
the
task-manager
branch
3 times, most recently
from
21a3798
to
d8b67c0
Compare
sjd78
changed the title
rszwajko
reviewed
Jun 19, 2024
| id: task.id ?? -1, | ||
| createUser: task.createUser ?? "", | ||
| updateUser: task.updateUser ?? "", | ||
| createTime: task.createTime ?? "", // TODO: date? |
There was a problem hiding this comment.
- with "flat" object approach it makes sense to pre-format the props - so I would use string-formatted dates
- similar logic for retrieving/formatting values is used in toCells mapper - we might won't to use common step at some point.
There was a problem hiding this comment.
Potential future work to harmonize the display formatting of the task's fields.
There was a problem hiding this comment.
I opened #1969 to capture this work once all the main task functions are merged.
Resolves: konveyor#1938 Add a queued tasks count badge plus and item drawer. - Use the standard `NotificationDrawer` attached to the `Page` layout to render the task manager item drawer. - Add a `TaskManagerContext` to control the count indicator and visibility of the drawer. This is a top level context so the task manager is available on all pages. - Add `TaskQueue` and query for the notification badge __Still Needs__: - Task rows in the notification drawer - Infinite scroll on the task list (or at least a load more link/icon, maybe a visual indicator that more can be fetched on scroll or click) - Individual task actions Related changes: - Update the `HeaderApp` to handle visibility of masthead toolbar items at the `ToolbarGroup` level. - Rename `SSOMenu` to `SsoToolbarItem`. Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
rszwajko
approved these changes
Jun 20, 2024
This was referenced Jun 20, 2024
This was referenced Jun 22, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1938
Add a queued tasks count badge and a task list drawer.
Add a
TaskManagerContextto control the count indicator and visibility of the drawer. This is a top level context so the task manager is available on all pages. The context itself monitors the task queue report endpoint1 that drives the notification badge count.Use the standard
NotificationDrawerattached to thePagelayout to render the task manager item drawer.The
TaskNotificationBadgeis integrated to the application'sHeaderApp.The
TaskManagerDrawershows the list of currently "queued" tasks2 in task id descending sort order (most recently created tasks on the top).Each task item is rendered in a "collapsed" state and after a click will render "expanded". The expanded state include the started timestamp.
Note 1: Until fetch more / infinite scroll is implemented in the task manager drawer list, only the first 20 queued tasks will be displayed.
Note 2: Task actions need to be added to the task items. These should reuse the same set of actions as the task table in ✨ Task table #1957.
Related changes:
Update the
HeaderAppto handle visibility of masthead toolbar items at theToolbarGrouplevel.Rename
SSOMenutoSsoToolbarItem.Updated the typing on a few task related API functions.
Footnotes
https://github.com/konveyor/tackle2-hub/issues/641 ↩
https://github.com/konveyor/tackle2-hub/pull/640 ↩